[GHC] #10439: Opt_ImplicitImportQualified doesn't work for constructor field name
#10439: Opt_ImplicitImportQualified doesn't work for constructor field name -------------------------------------+------------------------------------- Reporter: watashi | Owner: watashi Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.10.1 Keywords: | Operating System: Unknown/Multiple Architecture: x86 | Type of failure: GHC rejects Test Case: | valid program Blocking: | Blocked By: Differential Revisions: | Related Tickets: -------------------------------------+------------------------------------- {{{#!hs -- ghci -fimplicit-import-qualified Prelude> let tree = Data.Tree.Node 0 [] Prelude> Data.Tree.rootLabel tree 0 Prelude> let f i j = i { Data.Tree.rootLabel = j } <interactive>:4:17: ‘Data.Tree.rootLabel’ is not a (visible) constructor field name Prelude> import qualified Data.Tree Prelude Data.Tree> let f i j = i { Data.Tree.rootLabel = j } Prelude Data.Tree> f tree 1 Node {rootLabel = 1, subForest = []} }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10439> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10439: Opt_ImplicitImportQualified doesn't work for constructor field name -------------------------------------+------------------------------------- Reporter: watashi | Owner: watashi Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86 Type of failure: GHC rejects | Test Case: valid program | Blocking: Blocked By: | Differential Revisions: Phab:D900 Related Tickets: | -------------------------------------+------------------------------------- Changes (by watashi): * differential: => Phab:D900 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10439#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10439: Opt_ImplicitImportQualified doesn't work for constructor field name -------------------------------------+------------------------------------- Reporter: watashi | Owner: watashi Type: bug | Status: patch Priority: highest | Milestone: 7.12.1 Component: GHCi | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86 Type of failure: GHC rejects | Test Case: valid program | Blocking: Blocked By: | Differential Revisions: Phab:D900 Related Tickets: | -------------------------------------+------------------------------------- Changes (by simonpj): * priority: normal => highest * status: new => patch * milestone: => 7.12.1 Comment: I'm happy with the patch - thank you. Austin please land it. Simon -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10439#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10439: Opt_ImplicitImportQualified doesn't work for constructor field name -------------------------------------+------------------------------------- Reporter: watashi | Owner: watashi Type: bug | Status: patch Priority: highest | Milestone: 7.12.1 Component: GHCi | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86 Type of failure: GHC rejects | Test Case: valid program | Blocking: Blocked By: | Differential Revisions: Phab:D900 Related Tickets: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"1d6ead7d71ae9ad104f9bed9579462ce4a218594/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="1d6ead7d71ae9ad104f9bed9579462ce4a218594" Enable using qualified field of constructor in GHCi The -fimplicit-import-qualified made it possible to uses qualifed names in GHCi without explicitly import the modules. But it didn't work for field of constructor, this patch fixed this issue. Test Plan: cd testsuite/tests/rename/ && make cd testsuite/tests/ghci/ && make Reviewers: austin, simonpj Reviewed By: austin, simonpj Subscribers: bgamari, thomie Differential Revision: https://phabricator.haskell.org/D900 GHC Trac Issues: #10439 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10439#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10439: Opt_ImplicitImportQualified doesn't work for constructor field name -------------------------------------+------------------------------------- Reporter: watashi | Owner: watashi Type: bug | Status: patch Priority: highest | Milestone: 7.12.1 Component: GHCi | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: x86 Type of failure: GHC rejects | Test Case: valid program | ghci/scripts/T10439 Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D900 -------------------------------------+------------------------------------- Changes (by simonpj): * testcase: => ghci/scripts/T10439 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10439#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10439: Opt_ImplicitImportQualified doesn't work for constructor field name -------------------------------------+------------------------------------- Reporter: watashi | Owner: watashi Type: bug | Status: closed Priority: highest | Milestone: 7.12.1 Component: GHCi | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: x86 Type of failure: GHC rejects | Test Case: valid program | ghci/scripts/T10439 Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D900 -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10439#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC