[GHC] #15288: Figure out what to do about retainer profiling debugging code

#15288: Figure out what to do about retainer profiling debugging code -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- `rts/RetainerProfile.c` has a hope pile of code guarded by the unset-by- default `DEBUG_RETAINER` macro. I tried to resuscitate it while debugging #15287, but it seems like a bit of a lost cause. In particular, the `cost()` function which seems to be critical to the accounting done by in this code was removed in dbef766ce79e37a74468a07a93b15ba1f06fe8f8. While I can't tell for certain, it's possible that this "cost" notion coincides with the value currently computed by `closure_sizeW`. Regardless, we should either drop this code if it's beyond saving or fix it to do something useful. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15288 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#15288: Figure out what to do about retainer profiling debugging code -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonmar): I'm OK with removing it from the repo. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15288#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC