[GHC] #16019: Harbormaster: OS X build fails
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: Component: Runtime | Version: 8.7 System | Keywords: | Operating System: MacOS X Architecture: | Type of failure: Building GHC Unknown/Multiple | failed Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- From Build 64479 https://phabricator.haskell.org/harbormaster/build/64479/ {{{ rts/sm/CNF.c:1002:13: error: 486 error: declaration does not declare anything [-Werror ,-Wmissing-declarations] 487 FALLTHROUGH; 488 ^ 489 | 490 1002 | FALLTHROUGH; 491 | ^ 492 493 includes/Stg.h:201:21: error: 494 note: expanded from macro 'FALLTHROUGH' 495 | 496 201 | #define FALLTHROUGH GNU_ATTRIBUTE(fallthrough) 497 | ^ 498 #define FALLTHROUGH GNU_ATTRIBUTE(fallthrough) 499 ^ 500 501 includes/Stg.h:188:27: error: 502 note: expanded from macro 'GNU_ATTRIBUTE' 503 | 504 188 | #define GNU_ATTRIBUTE(at) __attribute__((at)) 505 | ^ 506 #define GNU_ATTRIBUTE(at) __attribute__((at)) 507 ^ }}} Marking this as highest priority because it is a regression and it breaks CI. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by trommler): * related: => #14613 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by trommler): * milestone: => 8.8.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by harpocrates): This is due to 6bb8aaa3b4fcebf8f0de2f81f00dcc20b857c4f5. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by carter): yup, i thought i had tested this properly on my side, but i guess not :( -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Phab:D5436 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D5436 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails
-------------------------------------+-------------------------------------
Reporter: trommler | Owner: (none)
Type: bug | Status: patch
Priority: highest | Milestone: 8.8.1
Component: Runtime System | Version: 8.7
Resolution: | Keywords:
Operating System: MacOS X | Architecture:
Type of failure: Building GHC | Unknown/Multiple
failed | Test Case:
Blocked By: | Blocking:
Related Tickets: #14613 | Differential Rev(s): Phab:D5436
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Phab:D5436 Wiki Page: | -------------------------------------+------------------------------------- Comment (by carter): @Ben: your logic means that clang will do " #define FALLTHROUGH GNU_ATTRIBUTE(fallthrough)" is that what you want? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: patch Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Phab:D5436 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Replying to [comment:7 carter]:
@Ben: your logic means that clang will do " #define FALLTHROUGH GNU_ATTRIBUTE(fallthrough)"
is that what you want?
I don't understand. After this patch `FALLTHROUGH` should be defined as {{{#!c #define FALLTHROUGH ((void)0) }}} Right? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#16019: Harbormaster: OS X build fails -------------------------------------+------------------------------------- Reporter: trommler | Owner: (none) Type: bug | Status: closed Priority: highest | Milestone: 8.8.1 Component: Runtime System | Version: 8.7 Resolution: fixed | Keywords: Operating System: MacOS X | Architecture: Type of failure: Building GHC | Unknown/Multiple failed | Test Case: Blocked By: | Blocking: Related Tickets: #14613 | Differential Rev(s): Phab:D5436 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16019#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC