#4931: hsc2hs emits invalid OPTIONS_GHC pragmas -------------------------------------+------------------------------------- Reporter: awson | Owner: thomie Type: bug | Status: patch Priority: low | Milestone: 8.0.1 Component: hsc2hs | Version: 7.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: driver/T4931 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1452 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"fbc2537c0b2cbe947684bb39669643f1ef9d96c0/ghc" fbc2537/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="fbc2537c0b2cbe947684bb39669643f1ef9d96c0" OPTIONS_GHC compiler flags may contain spaces (#4931) When a .hsc contains `#define FOO "bar baz"`, hsc2hs emits: {-# OPTIONS_GHC -optc-DFOO="bar baz" #-} Make sure GHC can compile this, by tweaking `HeaderInfo.getOptions` a bit. Test Plan: driver/T4931 Reviewers: austin, bgamari Reviewed By: bgamari Differential Revision: https://phabricator.haskell.org/D1452 GHC Trac Issues: #4931 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4931#comment:19> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler