Re: [GHC] #910: --make should have a -j flag for parallel building

#910: --make should have a -j flag for parallel building -------------------------------------+------------------------------------ Reporter: igloo | Owner: Type: feature request | Status: patch Priority: normal | Milestone: _|_ Component: Compiler | Version: 6.4.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: N/A | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by simonmar): I'm impressed, it looks like you've done a great job. Well done. The parallel upsweep itself would look much nicer written using ParIO from monad-par, but that's something for the future. Take a careful look at `reTypecheckLoop`, I'm not sure it's correct (see my inline comment). The `FastString` changes need some more commentary, as pointed out by others. There are good comments in the parallel upsweep patch though. You've obviously been careful to minimize the impact on sequential compilation performance, which is great. The parallel IO manager bug needs to be fixed before we can merge the patch though. We can't ship it with a bug that causes random compilation failure. Aside from the issues above, I'm happy with the patch. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/910#comment:30 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC