[GHC] #11127: Update cabal submodule to 1.22 branch HEAD

#11127: Update cabal submodule to 1.22 branch HEAD -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- For 7.10.3, this will fold in a critical fix for Mac (the Cabal side of #10568), along with a fix to prevent c-sources from being recompiled unnecessarily (a big deal when working with large C/C++ bindings). The commit is 5acbc41 https://github.com/haskell/cabal/tree/1.22 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22 branch HEAD -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Description changed by lukexi: Old description:
For 7.10.3, this will fold in a critical fix for Mac (the Cabal side of #10568), along with a fix to prevent c-sources from being recompiled unnecessarily (a big deal when working with large C/C++ bindings).
The commit is 5acbc41
New description: For 7.10.3, this will fold in a critical fix for Mac (the Cabal side of #10568), along with a fix to prevent c-sources from being recompiled unnecessarily (a big deal when working with large C/C++ bindings). The commit is `5acbc41` https://github.com/haskell/cabal/tree/1.22 -- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22 branch HEAD -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => wontfix Comment: 7.10.3 is a minor release before the quite major 8.0 and consequently we are trying to keep the delta small. This desire, coupled with the fact that Cabal can be easily updated after installation, convinced me that the potential risk that a bump (which involves more than 20k lines of changes) would carry outweighs the relatively minor benefits. Sorry! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22 branch HEAD -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by refold): I'd argue that bumping Cabal from 1.22.4.0 to 1.22.5.0 for a minor GHC release is a sensible thing to do. The diff is much smaller than 20K and contains only bugfixes. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22 branch HEAD -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: bug | Status: closed Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by refold): Basically, the only changes in Cabal 1.22.5.0 are: * [https://github.com/haskell/cabal/commit/1a64dcb0818ba609c4d6f1b60392802b43ad... The aforementioned Mac framework fix (a one-liner).] * [https://github.com/haskell/cabal/commit/eb4687233852b5a9b5544b815eed0a44a947... C sources recompilation fix.] * [https://github.com/haskell/cabal/commit/1c1228a808b55331ac1db6d71fd2f8533f5f... Support for Haddock response files.] So I vote for bumping Cabal from 1.22.4.0 to 1.22.5.0 for 7.10.3. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by lukexi): * status: closed => new * type: bug => task * resolution: wontfix => Old description:
For 7.10.3, this will fold in a critical fix for Mac (the Cabal side of #10568), along with a fix to prevent c-sources from being recompiled unnecessarily (a big deal when working with large C/C++ bindings).
The commit is `5acbc41`
New description: For 7.10.3, this will fold in a critical fix for Mac (the Cabal side of #10568), along with a fix to prevent c-sources from being recompiled unnecessarily (a big deal when working with large C/C++ bindings). The commit is `fb7ce39` https://github.com/haskell/cabal/tree/1.22 -- Comment: Hi Ben, I'll assume you misread the title and thought I was asking for a bump to Cabal actual HEAD, since that is indeed a 22K line diff : ). This is just a bump from 1.22.4 to 1.22.5 and it's about 58 lines. https://github.com/haskell/cabal/compare/75266d2222eeefccfc26f28ca5d6c2dccf6... I'll go ahead and reopen this based on that assumption, hope that's not rude : ). Mikhail tagged a 1.22.5 release so the relevant commit is now `75266d2`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by lukexi): (oops, I meant `fb7ce39`) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by hvr): Replying to [comment:5 lukexi]:
Mikhail tagged a 1.22.5 release so the relevant commit is now `fb7ce39`.
nope, he didn't... there's no git-signed annotated Git tag `Cabal-v1.22.5.0` yet (like there was for http://git.haskell.org/packages/Cabal.git/tag/Cabal-v1.22.4.0) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by refold): Yes, I just bumped the version in the .cabal file. If you want Cabal 1.22.5.0 to be released on Hackage first, I'll ask Ryan to cut a release. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: closed Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => wontfix Comment: I asked Mikhail and then Ryan to tag a release last week. Sadly this still hasn't happened and I really can't afford to push 7.10.3 off any farther given the proximity of 8.0. Sorry Luke, I'm afraid I won't be able to fulfill this request. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: closed Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by refold): I've just got a mail from Ryan and he says that he'll do a release today. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: new Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by refold): * status: closed => new * resolution: wontfix => Comment: Cabal-1.22.5.0 has just been released. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11127: Update cabal submodule to 1.22.5 -------------------------------------+------------------------------------- Reporter: lukexi | Owner: Type: task | Status: closed Priority: high | Milestone: 7.10.3 Component: libraries | Version: (other) | Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed Comment: Indeed, I managed to pull in the updated submodule before tagging the release. Looks like 7.10.3 will have a functional cabal afterall. Thanks for your patience everyone! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11127#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC