[GHC] #15072: Teach the testsuite driver about response files
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.2.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Currently `T14697` is disabled on Windows as that test produces a long enough command-line (mostly `-D` flags) that it runs amok of the Windows command-line length limit. It seems like the solution here will be to teach the testsuite driver to invoke GHC with a response file. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * component: Compiler => Test Suite -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.6.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * keywords: => ci-breakage -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner: (none)
Type: task | Status: new
Priority: normal | Milestone: 8.6.1
Component: Test Suite | Version: 8.2.2
Resolution: | Keywords: ci-breakage
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by ckoparkar): bgamari: I was considering picking this up. Before we "teach the testsuite driver to invoke GHC with a response file", we'll have to update the GHC executable itself to understand response file args right ? `ghc @ARGS_FILE` doesn't work, and I couldn't find any flag that allows us to specify this (I'm still looking). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by ckoparkar): * cc: ckoparkar (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Yes; GHC currently uses response files itself when invoking gcc but doesn't understand them itself. This should be fixed. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: ckoparkar Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by ckoparkar): * owner: (none) => ckoparkar Comment: Alright, so there are 2 things we'd like to do: (1) Update the GHC executable itself to understand response file arguments. (2) Update the testsuite. Since we're updating the executable, is there some process we have to follow (eg. announce on a specific mailing list) ? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: ckoparkar Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari):
Since we're updating the executable, is there some process we have to follow (eg. announce on a specific mailing list) ?
I don't believe anything in particular is necessary for this change. I view this largely as just implementing a missing feature. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: ckoparkar Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: 15732 | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by ckoparkar): * blockedby: => 15732 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: ckoparkar Type: task | Status: new Priority: normal | Milestone: 8.10.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: 15732 | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by int-index): The same issue plagues Darwin, see https://gitlab.haskell.org/ghc/ghc/-/jobs/34485 and https://github.com/alpmestan/ghc.nix/issues/22#issuecomment-463354397 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: ckoparkar Type: task | Status: new Priority: normal | Milestone: 8.10.1 Component: Test Suite | Version: 8.2.2 Resolution: | Keywords: ci-breakage Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: 15732 | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/438 -------------------------------------+------------------------------------- Changes (by RyanGlScott): * differential: => https://gitlab.haskell.org/ghc/ghc/merge_requests/438 Comment: It's interesting that `T14697` only seems to fail nondeterministically on Darwin. I wonder why this list of CLI arguments is too long on some runs but not on others? In any case, [https://gitlab.haskell.org/ghc/ghc/merge_requests/438 !438] disables `T14697` on Darwin (in addition to Windows). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15072#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15072: Teach the testsuite driver about response files
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner: ckoparkar
Type: task | Status: new
Priority: normal | Milestone: 8.10.1
Component: Test Suite | Version: 8.2.2
Resolution: | Keywords: ci-breakage
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: 15732 | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/438
-------------------------------------+-------------------------------------
Comment (by Marge Bot
participants (1)
-
GHC