[GHC] #11954: Associated pattern synonyms not included in haddock
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Running haddock on: {{{#!hs {-# LANGUAGE PatternSynonyms #-} module Foo ( A(P) ) where data A a = A pattern P = A }}} Just gives a data type A with no constructors, and no mention of the associated pattern synonym P. Attached is a patch for haddock that prints associated patterns as GADT constructors -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by darchon): * Attachment "haddock_assoc_pat_to_con.patch" added. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by darchon): Please ignore the {{{ import DynFlags (unsafeGlobalDynFlags) }}} in the attached patch, it's a leftover from some of my debugging. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by darchon): Github pull request for haddock: https://github.com/haskell/haddock/pull/494 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by darchon): * Attachment "haddock_bundled_pat_to_con.patch" added. Cleaned up version of earlier patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by darchon): * Attachment "0001-Display-bundled-pattern-synonyms-as-GADT- constructor.patch" added. Now in git format-patch style -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.0.1 => 8.0.2 Comment: Sadly this will need to be bumped to 8.0.2 as the current patch is still a bit rough around the edges. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.3 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.0.2 => 8.0.3 Comment: Bumping to 8.0.3. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by darchon): * milestone: 8.4.1 => 8.2.1 Comment: Hopefully https://github.com/haskell/haddock/commit/87c551fc668b9251f2647cce8772f205e1..., which is in haddock's master branch, can still be included for the 8.2.1 release. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by dfeuer): Replying to [comment:8 darchon]:
Hopefully https://github.com/haskell/haddock/commit/87c551fc668b9251f2647cce8772f205e1..., which is in haddock's master branch, can still be included for the 8.2.1 release.
GHC HQ prefers to ship only ''released'' packages. If Haddock can make a release real quick, we ''might'' be able to slip that change in under the wire. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11954: Associated pattern synonyms not included in haddock -------------------------------------+------------------------------------- Reporter: darchon | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1-rc3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed Comment: This commit is present in 8.2-rc3. Thanks for updating the milestone, darchon. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11954#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC