[GHC] #11472: Remove CallStack CPP guards in GHC 8.2

#11472: Remove CallStack CPP guards in GHC 8.2 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 7.10.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- GHC 7.10.1 didn't support `CallStack`, while its successors did. Yet in post-8.0 `master` (which needs to be buildable with the 7.10 series, including 7.10.1) references to CallStack have begun to sneak in to GHC. The first instance of this was 9d33adb6f352ad4e488067a8756928b3778920e0 but there will likely be more. I've fixed in this instance in Phab:D1812 by adding `#if` guards. These should be removed in GHC 8.2. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11472: Remove CallStack CPP guards in GHC 8.2 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by jstolarek): Actually, the first instance was in 80d7ce8038a100f6797a89755c893c6f67f18a30 - that also broke the build for me because the guard incorrectly said `>= 710` instead of `> 710`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11472: Remove CallStack CPP guards in GHC 8.2
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner:
Type: task | Status: new
Priority: normal | Milestone: 8.2.1
Component: Compiler | Version: 7.10.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari

#11472: Remove CallStack CPP guards in GHC 8.2 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): rwbarton astutely points out that `MIN_VERSION_GLASGOW_HASKELL`, which is used in the above commit (which was merged to `ghc-8.0` as well), was only introduced in ghc 7.10. Looks like we'll need to revert to `__GLASGOW_HASKELL__` in `ghc-8.0`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11472: Remove CallStack CPP guards in GHC 8.2 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * version: 7.10.3 => 8.0.1-rc1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11472: Remove CallStack CPP guards in GHC 8.2 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by rwbarton): Does 8.2 need to be able to build with 7.10.1? If so then we can't remove these CPP guards entirely until 8.4. This is an honest question, by the way. I don't know whether our policy is that 8.2 should be buildable by ''every'' 7.10.* release, or ''some'' 7.10.* release, or perhaps the ''last'' 7.10.* release. If we somehow released a compiler that was completely incapable of bootstrapping GHC, it would be a serious problem for the "every" policy. Is this policy written down somewhere? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11472: Remove CallStack CPP guards in GHC 8.4 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: task | Status: new Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.2.1 => 8.4.1 Comment: I think we should be conservative here; the cost of keeping the CPP is relatively small compared to the inconvenience of worrying about which 7.10 releases we can/can't build with. Bumping to 8.4. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11472: Remove CallStack CPP guards in GHC 8.4 -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1-rc1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: 8.6.1 => 8.4.1 Comment: This was carried out in c13720c8c6047844f659ad4ce684946b80c99bee. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11472#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC