[GHC] #8552: Rename StgArrWords to StgArrBytes
#8552: Rename StgArrWords to StgArrBytes ------------------------------------+------------------------------------- Reporter: Tarrasch | Owner: Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- Since #3800, `StgArrWords` contains a certain number of words and not bytes. One can easily forget this and make programming mistakes. For example if you try to store the number of words in the `bytes` field, the garbage collector won't honor your decision. (I learned the hard way :)) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8552 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8552: Rename StgArrWords to StgArrBytes -------------------------------------+------------------------------------ Reporter: Tarrasch | Owner: Type: task | Status: patch Priority: lowest | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by Tarrasch): * status: new => patch Comment: My attachment just adds a comment about the confusion that can happen. (And have happened :)) I bet somebody have good arguments to not rename this struct, so please comment on this suggestion. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8552#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8552: Rename StgArrWords to StgArrBytes
-------------------------------------+------------------------------------
Reporter: Tarrasch | Owner:
Type: task | Status: patch
Priority: lowest | Milestone:
Component: Compiler | Version: 7.6.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture: Unknown/Multiple
Type of failure: None/Unknown | Difficulty: Unknown
Test Case: | Blocked By:
Blocking: | Related Tickets:
-------------------------------------+------------------------------------
Comment (by Austin Seipp
#8552: Rename StgArrWords to StgArrBytes -------------------------------------+------------------------------------ Reporter: Tarrasch | Owner: Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by thoughtpolice): * status: patch => new Comment: Seems sensible to me. Merged. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8552#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8552: Rename StgArrWords to StgArrBytes -------------------------------------+------------------------------------- Reporter: Tarrasch | Owner: | siddhanathan Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by siddhanathan): * owner: => siddhanathan -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8552#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8552: Rename StgArrWords to StgArrBytes -------------------------------------+------------------------------------- Reporter: Tarrasch | Owner: | siddhanathan Type: task | Status: new Priority: lowest | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1233 -------------------------------------+------------------------------------- Changes (by siddhanathan): * differential: => Phab:D1233 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8552#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8552: Rename StgArrWords to StgArrBytes
-------------------------------------+-------------------------------------
Reporter: Tarrasch | Owner:
| siddhanathan
Type: task | Status: new
Priority: lowest | Milestone:
Component: Compiler | Version: 7.6.3
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Revisions: Phab:D1233
-------------------------------------+-------------------------------------
Comment (by Austin Seipp
#8552: Rename StgArrWords to StgArrBytes -------------------------------------+------------------------------------- Reporter: Tarrasch | Owner: | siddhanathan Type: task | Status: closed Priority: lowest | Milestone: 8.0.1 Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: Phab:D1233 -------------------------------------+------------------------------------- Changes (by thomie): * status: new => closed * resolution: => fixed * milestone: => 8.0.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8552#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC