[GHC] #7963: -ddump-minimal-imports should preserve "hiding" imports
#7963: -ddump-minimal-imports should preserve "hiding" imports -----------------------------+---------------------------------------------- Reporter: dsf | Owner: Type: bug | Status: new Priority: normal | Component: Compiler Version: 7.6.2 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- An input file like {{{ {-# LANGUAGE OverloadedStrings #-} module Hiding where import Prelude hiding (writeFile, unlines) import Data.Text (unlines) import Data.Text.IO (writeFile) main :: IO () main = writeFile "/tmp/foo" (unlines ["hello", "world"]) }}} compiled with -ddump-minimal-imports produces a .imports file containing {{{ import Data.Text ( unlines ) import Data.Text.IO ( writeFile ) }}} Without the import of Prelude the original file won't compile with the new imports. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7963> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7963: -ddump-minimal-imports should preserve "hiding" imports -----------------------------+---------------------------------------------- Reporter: dsf | Owner: Type: bug | Status: new Priority: normal | Component: Compiler Version: 7.6.2 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- Comment(by simonpj@…): commit 4c01e105a75776b31a4507102d00856d9239390e {{{ Author: Simon Peyton Jones <simonpj@microsoft.com> Date: Mon Jun 17 22:39:43 2013 +0100 Use ideclImplicit to filter out only *implict* Prelude imports (Trac #7963) The ideclImplicit flag didn't exist before, but it does now, and it makes this code simpler and makes it easy to fix Trac #7963. compiler/rename/RnNames.lhs | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7963#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7963: -ddump-minimal-imports should preserve "hiding" imports -------------------------------------------+-------------------------------- Reporter: dsf | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.6.2 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: rename/shoulld_compile/T7963 | Blockedby: Blocking: | Related: -------------------------------------------+-------------------------------- Changes (by simonpj): * status: new => closed * difficulty: => Unknown * resolution: => fixed * testcase: => rename/shoulld_compile/T7963 Comment: Good point, thank you. Simon -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7963#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7963: -ddump-minimal-imports should preserve "hiding" imports -------------------------------------------+-------------------------------- Reporter: dsf | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.6.2 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: rename/shoulld_compile/T7963 | Blockedby: Blocking: | Related: -------------------------------------------+-------------------------------- Comment(by simonpj@…): commit 73991d61642a3a7dc1305bfac773ee3f59920d09 {{{ Author: Simon Peyton Jones <simonpj@microsoft.com> Date: Tue Jun 18 10:55:15 2013 +0100 Remove redundant import, revealed by the fix to #7963 compiler/codeGen/StgCmmMonad.hs | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7963#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC