#8951: genSym uses atomic_inc but doesn't link arm_atomic_spin_lock ----------------------------------------+----------------------------- Reporter: cjwatson | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.8.1 Component: Build System | Version: 7.8.1-rc1 Resolution: | Keywords: Operating System: Linux | Architecture: arm Type of failure: Building GHC failed | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: ----------------------------------------+----------------------------- Changes (by nomeata): * milestone: => 7.8.1 Comment: Setting a milestone to make sure this is not lost. If this was presumptuous, please undo, or maybe change to 7.8.2. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8951#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8951: genSym uses atomic_inc but doesn't link arm_atomic_spin_lock -------------------------------------+------------------------------------- Reporter: cjwatson | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.8.4 Component: Build | Version: 7.8.1-rc1 System | Keywords: Resolution: | Architecture: arm Operating System: Linux | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by bgamari): * cc: bgamari (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8951#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8951: genSym uses atomic_inc but doesn't link arm_atomic_spin_lock -------------------------------------+------------------------------------- Reporter: cjwatson | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.8.4 Component: Build | Version: 7.8.1-rc1 System | Keywords: Resolution: | Architecture: arm Operating System: Linux | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by nomeata): More info: `genSym.c` is linked into libghcHS. It contains code that depends on `THREADED_RTS`, but that’s a bit fishy: There is only one `libghcHS` that needs to work with both threaded and non-threaded RTSs. This code in `compiler/ghc.mk` might be related: {{{ ifeq "$(GhcThreaded)" "YES" # We pass THREADED_RTS to the stage2 C files so that cbits/genSym.c will bring # the threaded version of atomic_inc() into scope. compiler_stage2_CONFIGURE_OPTS += --ghc-option=-optc-DTHREADED_RTS endif }}} So one thing I’m trying is to provide the stubs from `rts/OldARMAtomic.c` even in the unthreaded RTS. It will be dead code, but at least the linker will be happy. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8951#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8951: genSym uses atomic_inc but doesn't link arm_atomic_spin_lock -------------------------------------+------------------------------------- Reporter: cjwatson | Owner: Type: bug | Status: patch Priority: normal | Milestone: 7.8.4 Component: Build | Version: 7.8.1-rc1 System | Keywords: Resolution: | Architecture: arm Operating System: Linux | Difficulty: Unknown Type of failure: Building | Blocked By: GHC failed | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by Austin Seipp ): In [changeset:"df1307f079ae69dcd735e0973de987b141d509da/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="df1307f079ae69dcd735e0973de987b141d509da" Link pre-ARMv6 spinlocks into all RTS variants Summary: For compatibility with ARM machines from pre v6, the RTS provides implementations of certain atomic operations. Previously, these were only included in the threaded RTS. But ghc (the library) contains the code in compiler/cbits/genSym.c, which uses these operations if there is more than one capability. But there is only one libHSghc, so the linker wants to resolve these symbols in every case. By providing these operations in all RTSs, the linker is happy. The only downside is a small amount of dead code in the non-threaded RTS on old ARM machines. Test Plan: It helped here. Reviewers: bgamari, austin Reviewed By: bgamari, austin Subscribers: carter, thomie Differential Revision: https://phabricator.haskell.org/D564 GHC Trac Issues: #8951 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8951#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler