[GHC] #11468: testsuite should ignore config files
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Keywords: newcomer | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I always get a few test failures like the following. {{{ =====> T9360a(normal) 1 of 3 [0, 0, 0] cd ./driver && "/Users/gridaphobe/Source/ghc/build/D1805/inplace/test spaces/ghc-stage2" --interactive -e "" </dev/null > T9360a.run.stdout 2> T9360a.run.stderr Actual stderr output differs from expected: --- /dev/null 2016-01-20 16:43:09.000000000 -0800 +++ ./driver/T9360a.run.stderr.normalised 2016-01-20 16:43:09.000000000 -0800 @@ -0,0 +1,11 @@ +cannot satisfy -package pretty-show + (use -v for more information) + +<no location info>: + Could not find module ‘Text.Show.Pretty’ + It is not a module in the current program, or in any known package. + +<interactive>:7:25: + Variable not in scope: ppShow :: a -> String + +<interactive>:1:1: Not in scope: ‘pprint’ \ No newline at end of file Actual stdout output differs from expected: }}} The failure is due to my `~/.ghci` file, which loads a few packages that ghc-head obviously hasn't built. The testsuite should ignore `~/.ghci` and any other user configuration files that might affect ghc. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by rwbarton): In general the testsuite handles this on a test-by-test basis, specifying `-ignore-dot-ghci` when using `--interactive`. In this case, though, this happened to uncover a real bug: we certainly shouldn't print the "Loaded GHCi configuration" message in `ghc -e`! Will file a new ticket for that. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by gridaphobe): I get these types of errors on three tests, so I guess they're probably missing `-ignore-dot-ghci` {{{ make test TEST="load_short_name T9360a T9360b" }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by rwbarton): I added `-ignore-dot-ghci` to those tests in 2ffc2606cfc58768ddc6dd53f270ba7088c43f3c. We could factor out all this repetition, though. How about a variable `TEST_HC_INTERACTIVE_OPTS` that is set to `$(TEST_HC_OPTS) --interactive -ignore-dot-ghci -v0`? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): Replying to [comment:3 rwbarton]:
We could factor out all this repetition, though. How about a variable `TEST_HC_INTERACTIVE_OPTS` that is set to `$(TEST_HC_OPTS) --interactive -ignore-dot-ghci -v0`?
Good idea. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: thomie Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2265 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * owner: => thomie * keywords: newcomer => * differential: => Phab:D2265 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: thomie Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2265 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"bdc555885b8898684549eca70053c9ce0ec7fa39/ghc" bdc55588/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="bdc555885b8898684549eca70053c9ce0ec7fa39" Testsuite: introduce TEST_HC_OPTS_INTERACTIVE (#11468) Refactoring only. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: thomie Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2265 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"d40682ec74d802376d7cf50f2d3612b3292b29c5/ghc" d40682e/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="d40682ec74d802376d7cf50f2d3612b3292b29c5" Testsuite: don't use --interactive in Makefiles Add a linter to encourage the use of `$(TEST_HC_OPTS_INTERACTIVE)` instead of `$(TEST_HC_OPTS) --interactive -ignore-dot-ghci -v0`. It's too easy to forget one of those flags when adding a new test. Update submodule hpc. Reviewed by: austin Differential Revision: https://phabricator.haskell.org/D2265 GHC Trac Issues: #11468 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11468: testsuite should ignore config files -------------------------------------+------------------------------------- Reporter: gridaphobe | Owner: thomie Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Test Suite | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2265 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => closed * resolution: => fixed * milestone: => 8.2.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11468#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC