[GHC] #9963: GHCi panic with --print-libdir flag
#9963: GHCi panic with --print-libdir flag -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: Type: bug | Status: new Priority: high | Milestone: 7.10.1 Component: Driver | Version: 7.9 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: GHCi crash Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Reported on GHC devs: {{{ $ ghc-stage2 --print-libdir /dane/projekty/ghc/build/inplace/lib $ ghc-stage2 --interactive --print-libdir ghc-stage2: panic! (the 'impossible' happened) (GHC version 7.9.20141222 for x86_64-unknown-linux): ghc-stage2: panic! (the 'impossible' happened) (GHC version 7.9.20141222 for x86_64-unknown-linux): v_unsafeGlobalDynFlags: not initialised Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} Does not happen with GHC 7.8.x. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9963> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9963: GHCi panic with --print-libdir flag -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: thomie Type: bug | Status: new Priority: high | Milestone: 7.10.1 Component: Driver | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHCi crash | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by thomie): * owner: => thomie Comment: I know what's going on, just need to write a patch. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9963#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9963: GHCi panic with --print-libdir flag -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: thomie Type: bug | Status: patch Priority: high | Milestone: 7.10.1 Component: Driver | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHCi crash | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | driver/T9963 | Blocking: | Differential Revisions: Phab:D730 -------------------------------------+------------------------------------- Changes (by thomie): * status: new => patch * testcase: => driver/T9963 * differential: => Phab:D730 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9963#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9963: GHCi panic with --print-libdir flag -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: thomie Type: bug | Status: patch Priority: high | Milestone: 7.10.1 Component: Driver | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHCi crash | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | driver/T9963 | Blocking: | Differential Revisions: Phab:D730 -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"5166ee94e439375a4e6acb80f88ec6ee65476bbd/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="5166ee94e439375a4e6acb80f88ec6ee65476bbd" Dont call unsafeGlobalDynFlags if it is not set Parsing of static and mode flags happens before any session is started, i.e., before the first call to 'GHC.withGhc'. Therefore, to report errors for invalid usage of these two types of flags, we can not call any function that needs DynFlags, as there are no DynFlags available yet (unsafeGlobalDynFlags is not set either). So we always print "on the commandline" as the location, which is true except for Api users, which is probably ok. When reporting errors for invalid usage of dynamic flags we /can/ make use of DynFlags, and we do so explicitly in DynFlags.parseDynamicFlagsFull. Before, we called unsafeGlobalDynFlags when an invalid (combination of) flag(s) was given on the commandline, resulting in panics (#9963). This regression was introduced in 1d6124de. Also rename showSDocSimple to showSDocUnsafe, to hopefully prevent this from happening again. Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D730 GHC Trac Issues: #9963 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9963#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9963: GHCi panic with --print-libdir flag -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: thomie Type: bug | Status: merge Priority: high | Milestone: 7.10.1 Component: Driver | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHCi crash | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | driver/T9963 | Blocking: | Differential Revisions: Phab:D730 -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9963#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9963: GHCi panic with --print-libdir flag -------------------------------------+------------------------------------- Reporter: jstolarek | Owner: thomie Type: bug | Status: closed Priority: high | Milestone: 7.10.1 Component: Driver | Version: 7.9 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHCi crash | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | driver/T9963 | Blocking: | Differential Revisions: Phab:D730 -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: merge => closed * resolution: => fixed Comment: Merged to `ghc-7.10` (via f92acd8ed223ebbbf62fab930c6c346f5531d431). -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9963#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC