#7700: iOS patch no 3: enable/disable terminfo more precisely by os ------------------------------+--------------------------------------------- Reporter: StephenBlackheath | Owner: Type: bug | Status: patch Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: ------------------------------+--------------------------------------------- Changes (by StephenBlackheath): * status: new => patch Comment: Thanks for the previous commits and apologies for forgetting a ;; I hope this makes sense. The reason why I can't just leave out $(eval $(call addPackage,terminfo)) like the existing code does with Windows is that if we do that, then the terminfo never gets included at all. That's because it doesn't get added to PACKAGES_STAGE1 so the code below never includes the module. That's no good to us because we need it built in stage 0. {{{ ifneq "$(CLEANING)" "YES" BUILD_DIRS += \ $(patsubst %, libraries/%, $(PACKAGES_STAGE1)) endif }}} -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#7700: iOS patch no 3: enable/disable terminfo more precisely by os ------------------------------+--------------------------------------------- Reporter: StephenBlackheath | Owner: Type: bug | Status: patch Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking: | Related: ------------------------------+--------------------------------------------- Changes (by StephenBlackheath): * status: infoneeded => patch Comment: That was tricky. With 3e I tested a native linux build and an ios cross build to the start of the stage2 compiler, so I'm very confident now. So, please review. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#7700: iOS patch no 3: enable/disable terminfo more precisely by os ----------------------------------+----------------------------------------- Reporter: StephenBlackheath | Owner: Type: feature request | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.7 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ----------------------------------+----------------------------------------- Changes (by StephenBlackheath): * type: bug => feature request -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#7700: iOS patch no 3: enable/disable terminfo more precisely by os ----------------------------------+----------------------------------------- Reporter: StephenBlackheath | Owner: igloo Type: feature request | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.7 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: 7724 Related: | ----------------------------------+----------------------------------------- Comment(by ian@…): commit dd9da49ceda5bd0d6c860604ace0ca9829199fe5 {{{ Author: Ian Lynagh Date: Fri Mar 1 22:29:19 2013 +0000 Fix when terminfo is built; fixes #7700 We now use the 'host' to determine whether stage0 builds terminfo, and 'target' to determine whether stage1 does. We don't build it if the platform is either Windows or ios. ghc.mk | 6 +++++- mk/project.mk.in | 7 +++++++ 2 files changed, 12 insertions(+), 1 deletions(-) }}} -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#7700: iOS patch no 3: enable/disable terminfo more precisely by os --------------------------------+------------------------------------------- Reporter: StephenBlackheath | Owner: Type: feature request | Status: new Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.7 Resolution: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: | Blockedby: Blocking: 7724 | Related: --------------------------------+------------------------------------------- Changes (by StephenBlackheath): * owner: igloo => * status: closed => new * resolution: fixed => Comment: Your changes don't quite fix it for darwin -> iOS, because of this sequence of events: 1. On a darwin -> iOS, PACKAGES_STAGE0 gets terminfo but PACKAGES_STAGE1 doesn't. 2. This line works for everything in PACKAGES_STAGE1, but there's no similar line for PACKAGES_STAGE0 {{{BUILD_DIRS += $(patsubst %, libraries/%, $(PACKAGES_STAGE1))}}} 3. So {{{libraries/terminfo}}} never gets added to BUILD_DIRS. The output is this: {{{ Configuring ghc-pkg-6.9... ghc-cabal: At least the following dependencies are missing: terminfo ==0.3.2.5 make[1]: *** [utils/ghc-pkg/dist/package-data.mk] Error 1 make: *** [all] Error 2 }}} I attach a patch to fix it. When working on it before I suspected some order dependence in the inclusion of the build dirs, and I haven't sanity tested a complete build yet. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#7700: iOS patch no 3: enable/disable terminfo more precisely by os --------------------------------+------------------------------------------- Reporter: StephenBlackheath | Owner: igloo Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.7 Resolution: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: | Blockedby: Blocking: 7724 | Related: --------------------------------+------------------------------------------- Changes (by igloo): * owner: => igloo -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#7700: iOS patch no 3: enable/disable terminfo more precisely by os --------------------------------+------------------------------------------- Reporter: StephenBlackheath | Owner: igloo Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.7 Resolution: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: | Blockedby: Blocking: 7724 | Related: --------------------------------+------------------------------------------- Comment(by ian@…): commit 056997a285a368f5f78905b4b325a3258484f71d {{{ Author: Ian Lynagh Date: Sun Mar 3 13:35:41 2013 +0000 Add PACKAGES_STAGE0 to build-dirs too; fixes #7700 This is sometimes needed when cross-compiling, as some packages may be built in stage 0 but not stage 1. In order to make everything work out, this also removes the requirement that the build-dirs are in dependency order ghc.mk | 16 ++++++++-------- rules/haddock.mk | 5 ++++- 2 files changed, 12 insertions(+), 9 deletions(-) }}} -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7700#comment:14 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler