[GHC] #10377: Remove double negative of ("Unregisterised", "NO")
#10377: Remove double negative of ("Unregisterised", "NO") -------------------------------------+------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- The `settings` file has variable named `Unregisterised` which on most arches is sed to `NO`. I propose that the variable be renamed to `Registered` (dropping the "ised" part as well) so that: {{{ Old New ("Unregisterised", "NO") -> ("Registered", "YES") ("Unregisterised", "YES") -> ("Registered", "NO") }}} Unless someone can come up with a good reason why it should stay as it is, I will submit a patch for this to phabricator. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10377 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10377: Remove double negative of ("Unregisterised", "NO") -------------------------------------+------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by erikd): May even make more sense to rename the variable `GhcCallingConvention`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10377#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10377: Remove double negative of ("Unregisterised", "NO") -------------------------------------+------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by rwbarton): In general I don't like making changes like this because the established terminology is found in documentation/papers/blog posts/StackOverflow answers and changing the terminology effectively reduces the value of all those resources. The term "Registered" in particular is not good since it already has a much more common meaning in the context of software. We don't want people thinking they have to register their copy of GHC! Personally I don't find `("Unregisterised", "NO")` confusing; I'm not sure why, but I think it might be because registerised is the "default", so unregisterised sticks out as a "positive", unusual property, despite the etymology. Consider also that unregisterised builds are enabled by `--enable-unregisterised`, we don't talk about disabling registerised- ness. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10377#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10377: Remove double negative of ("Unregisterised", "NO") -------------------------------------+------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by erikd): Replying to [comment:2 rwbarton]:
Personally I don't find `("Unregisterised", "NO")` confusing;
I'm hitting it all the time because I'm working on both armhf which is "registerised" and aarch64 which currently isn't (working on that). `("Unregisterised", "YES")` doesnt give me much trouble, but *every* time I see `("Unregisterised", "NO")` I have a huge double take and have to think about it.
unregisterised builds are enabled by `--enable-unregisterised`, we don't talk about disabling registerised-ness.
No, but `--disable-ghc-calling-convention` is far more obvious than what we have now. Its also makes it more obvious that `ghc-calling-convention` is the *default*. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10377#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10377: Remove double negative of ("Unregisterised", "NO") -------------------------------------+------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by thomie): I agree with Reid here: wontfix. It's not just the settings file either, grep shows over 100 uses of the word unregisterised. * platformUnregisterised * targetUnregisterised * "Compiler unregisterised" * etc. Only changing the name in configure/settings file would just make things confusing. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10377#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#10377: Remove double negative of ("Unregisterised", "NO") -------------------------------------+------------------------------------- Reporter: erikd | Owner: erikd Type: bug | Status: closed Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: wontfix | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by erikd): * status: new => closed * resolution: => wontfix -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10377#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC