#12610: Emit tab warning promptly -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: new Priority: high | Milestone: 8.0.2 Component: Compiler | Version: 8.0.1 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by dfeuer): Actually, the problem ''seems'' to be that the lexer adds tab warnings to some sort of warning log, and then `GHC.parser` only calls `getMessages` to retrieve a warning log summary when the parse is successful. We should probably change that to get at least some of the warnings in case of an unsuccessful parse. If it's impossible to change the type of `GHC.parser` between minor versions, then we could either add a function with the right type to use for `ghc` proper, or we could temporarily change `GHC.parser` to dump certain warnings into the error bucket. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12610#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12610: Emit tab warning promptly -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: Type: bug | Status: new Priority: high | Milestone: 8.0.3 Component: Compiler | Version: 8.0.1 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.0.2 => 8.0.3 Comment: I don't think this will happen for 8.0.2. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12610#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12610: Emit tab warning promptly -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dalaing Type: bug | Status: new Priority: high | Milestone: 8.0.3 Component: Compiler | Version: 8.0.1 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by dalaing): It looks like these are the various warnings that can be generated by the parser: If `Opt_WarnTabs` is set: * the tab warnings are collected and summarised If `Opt_WarnUnrecognisedPragmas` is set: * "Unrecognised pragma" If `Opt_WarnAlternativeLayoutRuleTransitional` is set: * "`where' clause at the same depth as implicit layout block" * "`|' at the same depth as implicit layout block" I think it's probably reasonable to print all of the warnings generated during parsing in the event of an unsuccessful parse. The other option would be to print the tab warning and suppress the others. I'm not sure we have enough structure in the warnings at the moment to do anything more fine grained unless we filtered them based on their warning strings. Adding an ADT for the warnings would help with that, and could be a positive step for later, but it's not something we need right now if folks agree that we always want to print all of the warnings on an unsuccessful parse. I'm going to start working on a change that prints warnings on unsuccessful parses (except perhaps for HeaderInfo.getImports, which has a note in it about not logging warning) and see how that goes. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12610#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12610: Emit tab warning promptly -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dalaing Type: bug | Status: new Priority: high | Milestone: 8.0.3 Component: Compiler | Version: 8.0.1 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by dalaing): It looks like getting this to work while keeping the ability to run the parser with a pure function might involve modifying the `PFailed` constructor from the `ParseResult` data type. It's not the end of the world, but I figure it's worth mentioning in case folks have objections. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12610#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12610: Emit tab warning promptly -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dalaing Type: bug | Status: new Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.2.1 => 8.4.1 Comment: This won't happen for 8.2. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12610#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12610: Emit tab warning promptly -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: dalaing Type: bug | Status: patch Priority: high | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3584 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"49012ebc9ed44a0b1f8de3781e15c8115d3074f8/ghc" 49012ebc/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="49012ebc9ed44a0b1f8de3781e15c8115d3074f8" Print warnings on parser failures (#12610). Test Plan: validate Reviewers: austin, bgamari, simonmar, mpickering Reviewed By: mpickering Subscribers: mpickering, rwbarton, thomie GHC Trac Issues: #12610 Differential Revision: https://phabricator.haskell.org/D3584 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12610#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler