[GHC] #15373: core-spec.pdf contains parse errors
#15373: core-spec.pdf contains parse errors -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.4.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- After commit 2fbe0b5171fd5639845b630faccb9a0c3b564df7, `core-spec.pdf` now contains several gnarly looking parse errors (which I'll attach screenshots of separately). This is because `nth` coercion typing rule was extended to take a role as an argument, but the uses of `nth` in the `S_Push`, `S_CPush`, and `S_CasePush` rules were never updated to reflect this. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15373> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15373: core-spec.pdf contains parse errors -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * Attachment "core-spec1.png" added. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15373> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15373: core-spec.pdf contains parse errors -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * Attachment "core-spec2.png" added. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15373> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15373: core-spec.pdf contains parse errors -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4965 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: goldfire (added) * status: new => patch * differential: => Phab:D4965 Comment: I took a stab at fixing this in Phab:D4965. Richard, please check my work! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15373#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15373: core-spec.pdf contains parse errors -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.4.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4965 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ryan Scott <ryan.gl.scott@…>): In [changeset:"8b6a9e5575fc848dc03b50b415aa57447654662f/ghc" 8b6a9e5/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="8b6a9e5575fc848dc03b50b415aa57447654662f" Fix parse errors in core-spec.pdf Summary: `core-spec.pdf` was emitting parse errors due to not specifying role arguments in some uses of `nth`. This patch adds those role arguments. (Credit goes to Richard Eisenberg for actually figuring out what said arguments should be.) Test Plan: Read it Reviewers: goldfire, bgamari Reviewed By: goldfire Subscribers: rwbarton, thomie, carter GHC Trac Issues: #15373 Differential Revision: https://phabricator.haskell.org/D4965 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15373#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15373: core-spec.pdf contains parse errors -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.4.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4965 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15373#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC