[GHC] #9057: Remove /usr/bin/… references
#9057: Remove /usr/bin/… references -------------------------------------------+------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.8.2 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 hour) | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: -------------------------------------------+------------------------------- The use of /usr/bin/perl in sync-all makes it difficult to work with on distros which don't store binaries in /usr/bin, such as NixOS. A more portable solution would be to use /usr/bin/env perl. It'd be very nice if someone turned such shebangs to use env rather than direct reference. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by Joachim Breitner <mail@…>): In [changeset:"34db5ccf52ec2a1b5e953c282d0c52a7fc82c02a/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="34db5ccf52ec2a1b5e953c282d0c52a7fc82c02a" Replace all #!/usr/bin/perl with #!/usr/bin/env perl As suggested in #9057. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: closed Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by nomeata): * status: new => closed * resolution: => fixed Comment: Quite right; fixed. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: closed Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by Fuuzetsu): Ah, while I did say /usr/bin/perl, I should have perhaps said /usr/bin/anything. {{{ ./libraries/terminfo/Setup.lhs:#!/usr/local/bin/runhaskell ./libraries/containers/benchmarks/bench-cmp.pl:#!/usr/bin/perl ./distrib/cross-port:#! /bin/bash ./configure: echo '#! /bin/cat ./testsuite/tests/rename/prog006/Setup.lhs:#!/usr/bin/runhaskell ./utils/count_lines/count_lines.lprl:#! /usr/bin/perl ./utils/pvm/debugger.emacs:#!/bin/csh -f ./utils/pvm/debugger2:#!/bin/csh -f ./compiler/count_bytes:#! /usr/local/bin/perl ./autom4te.cache/output.1: echo '#! /bin/cat ./autom4te.cache/output.0: echo '#! /bin/cat }}} Should I create a separate ticket for above? There are some in ./libraries so I should probably be filing with them, but many aren't. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by nomeata): * status: closed => new * resolution: fixed => Comment: I’ve reopened the ticket. You can also create a patch (or branch on your github fork) if you feel like it. How should arguments like in `/bin/csh -f` be treated? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: new Priority: low | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by Fuuzetsu): * priority: normal => low Comment: As far as I can tell, there's no way to pass such flags to programs while using `env` and these flags have to be accomodated for on script-by-script basis. So for example `#!/usr/bin/perl -w` becomes `#!/usr/bin/env perl` and `use warnings;` should be set instead of using `-w`. I'll look into patching out the paths I mentioned in the following few days if I get some time. It is of no high priority to me at the moment as during the build process my distro's tools patch up the shebangs anyway but it's a matter of principle. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: patch Priority: low | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D237 | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => patch * differential: => Phab:D237 Comment: All fixed, except: * libraries are maintained on github * configure and autom4te.cache are created are by autotools -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: patch Priority: low | Milestone: Component: Build | Version: 7.8.2 System | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D237 | -------------------------------------+------------------------------------- Comment (by Austin Seipp <austin@…>): In [changeset:"d5e4874833054f1789289c433be292ae3e9bd7d0/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="d5e4874833054f1789289c433be292ae3e9bd7d0" Change all hashbangs to /usr/bin/env (#9057) Summary: ``` git grep -l '#!' | xargs sed -i 's|#!.*/bin/\([^ ]*\)$|#!/usr/bin/env \1|' ``` and some manual tweaking Test Plan: harbormaster Reviewers: austin Subscribers: hvr, simonmar, ezyang, carter Differential Revision: https://phabricator.haskell.org/D237 GHC Trac Issues: #9057 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: closed Priority: low | Milestone: 7.10.1 Component: Build | Version: 7.8.2 System | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D237 | -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => closed * resolution: => fixed * milestone: => 7.10.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9057: Remove /usr/bin/… references -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: task | Status: closed Priority: low | Milestone: 7.10.1 Component: Build | Version: 7.8.2 System | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 Unknown/Multiple | hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D237 | -------------------------------------+------------------------------------- Comment (by Austin Seipp <austin@…>): In [changeset:"d997ca85a33f34f9f461096eb1b25d5f25b53072/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="d997ca85a33f34f9f461096eb1b25d5f25b53072" Don't use absolute paths for perl in validate Summary: This will *not* work on NixOS for example. Reviewers: austin Reviewed By: austin Subscribers: thomie, carter Differential Revision: https://phabricator.haskell.org/D479 GHC Trac Issues: #9057 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9057#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC