[GHC] #14891: Cabal bump broke ext-interp tests on Darwin
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.4.1 Component: Compiler | Version: 8.2.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Since a9f680f631e2 the testsuite has been failing with [[https://phabricator.haskell.org/harbormaster/build/42193|broken ext- interp tests]] on Darwin. I also see this on the ghc-8.4 branch. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.4.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Strangely enough when preparing the final release tarball I noticed that the failure manifested as a linker error, {{{ =====> T9262(ext-interp) 1 of 1 [0, 0, 0] cd "./th/T9262.run" && "/Users/bgamari/bin- dist-8.4.1-Darwin/ghc/inplace/bin/ghc-stage2" -c T9262.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show- caret -dno-debug-output -XTemplateHaskell -package template-haskell -fexternal-interpreter -v0 Compile failed (exit code 1) errors were: ghc-iserv.bin: lookupSymbol failed in relocateSection (RELOC_GOT) /Users/bgamari/bin-dist-8.4.1-Darwin/ghc/libraries/integer-gmp/dist- install/build/HSinteger-gmp-1.0.1.0.o: unknown symbol `___gmp_rands' ghc-stage2: unable to load package `integer-gmp-1.0.1.0' }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: hvr Type: bug | Status: new Priority: highest | Milestone: 8.4.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * owner: (none) => hvr -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: hvr Type: bug | Status: new Priority: highest | Milestone: 8.4.1 Component: Compiler | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"df7ac37d43bdbabbde9b09344f9425e8e5a879ff/ghc" df7ac37d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="df7ac37d43bdbabbde9b09344f9425e8e5a879ff" Fixup include of gmp/config.mk to use new location This wasn't spotted rightaway in 8f0b2f5eadf0fcb47c581907205a9db686214a69 because the include-site deliberately ignored include-errors as a Hack with the justification below:
Hack. The file gmp/config.mk doesn't exist yet after running ./configure in the toplevel (ghc) directory. To let some toplevel make commands such as sdist go through, right after ./configure, don't consider this an error.
This may have contributed to #14891. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: hvr Type: bug | Status: closed Priority: highest | Milestone: 8.4.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: hvr Type: bug | Status: closed Priority: highest | Milestone: 8.4.1 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by hvr): Replying to [comment:1 bgamari]:
{{{ =====> T9262(ext-interp) 1 of 1 [0, 0, 0] cd "./th/T9262.run" && "/Users/bgamari/bin- dist-8.4.1-Darwin/ghc/inplace/bin/ghc-stage2" -c T9262.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show- caret -dno-debug-output -XTemplateHaskell -package template-haskell -fexternal-interpreter -v0 Compile failed (exit code 1) errors were: ghc-iserv.bin: lookupSymbol failed in relocateSection (RELOC_GOT) /Users/bgamari/bin-dist-8.4.1-Darwin/ghc/libraries/integer-gmp/dist- install/build/HSinteger-gmp-1.0.1.0.o: unknown symbol `___gmp_rands' ghc-stage2: unable to load package `integer-gmp-1.0.1.0' }}}
Alex discovered, this had been reported already some time ago at https://mail.haskell.org/pipermail/ghc-devs/2017-June/014325.html I also noticed that GHC 8.4.1 for OSX uses the in-tree GMP library; while all tests/validation I did on OSX, where with some system-installed libgmp 6.x -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14891: Cabal bump broke ext-interp tests on Darwin -------------------------------------+------------------------------------- Reporter: bgamari | Owner: hvr Type: bug | Status: closed Priority: highest | Milestone: 8.4.2 Component: Compiler | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.4.1 => 8.4.2 Comment: Unfortunately due to an oversight in the release preparation process, the fix for this issue was not included in the 8.4.1 release. It will, however, be present in the soon-to-arrive 8.4.2. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14891#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC