[GHC] #13076: GHC panics can cause text-formatting changes from colorized error messages to linger
Spam detection software, running on the system "mail.haskell.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: #13076: GHC panics can cause text-formatting changes from colorized error messages to linger + Reporter: RyanGlScott | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: #8809, #12785 Differential Rev(s): | Wiki Page: + This bug relies on GHC panicking right after emitting a normal error message, so take note that I reproduced this error using a GHC HEAD build at commit 508811004d1806b28a91c3ff4a5c2247e2ad4655, and if #12785 is fixed, then this won't be reproducible anymore. If I compile this program from #12785: [...] Content analysis details: (7.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.2 MISSING_HEADERS Missing To: header 5.0 UNWANTED_LANGUAGE_BODY BODY: Message written in an undesired language
#13076: GHC panics can cause text-formatting changes from colorized error messages to linger -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #8809, #12785 | Differential Rev(s): Phab:D2932 Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * differential: => Phab:D2932 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13076#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13076: GHC panics can cause text-formatting changes from colorized error messages to linger -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: Type: bug | Status: patch Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #8809, #12785 | Differential Rev(s): Phab:D2932 Wiki Page: | -------------------------------------+------------------------------------- Changes (by dfeuer): * priority: normal => high * status: new => patch * milestone: => 8.2.1 Comment: I'm bumping the priority on this because it really messes with users. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13076#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13076: GHC panics can cause text-formatting changes from colorized error messages to linger -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: Type: bug | Status: patch Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #8809, #12785 | Differential Rev(s): Phab:D2932 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"22845adcc51b40040b9d526c36d2d36edbb11dd7/ghc" 22845ad/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="22845adcc51b40040b9d526c36d2d36edbb11dd7" Fix terminal corruption bug and clean up SDoc interface. - Fix #13076 by wrapping `printDoc_` so that the terminal color is reset even if an exception occurs. - Add `printSDoc`, `printSDocLn`, and `bufLeftRenderSDoc` to keep `SDoc` values abstract (they are wrappers of `printDoc_`, `printDoc`, and `bufLeftRender` respectively). - Remove unused function: `printForAsm` Test Plan: manual Reviewers: RyanGlScott, austin, dfeuer, bgamari Reviewed By: dfeuer, bgamari Subscribers: dfeuer, mpickering, thomie Differential Revision: https://phabricator.haskell.org/D2932 GHC Trac Issues: #13076 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13076#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#13076: GHC panics can cause text-formatting changes from colorized error messages to linger -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: Type: bug | Status: closed Priority: high | Milestone: 8.2.1 Component: Compiler | Version: 8.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: #8809, #12785 | Differential Rev(s): Phab:D2932 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/13076#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC