[GHC] #16217: check-api-annotations should check that an annotation does not precede its span
#16217: check-api-annotations should check that an annotation does not precede its span -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect API Unknown/Multiple | annotation Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- For an API annotation to be useful, it must not occur before the span it is enclosed in. So, for `check-api-annotation` output, a line such as {{{ ((Test16212.hs:3:22-36,AnnOpenP), [Test16212.hs:3:21]), }}} should be flagged as an error, as the `AnnOpenP` location of `3:21` precedes its enclosing span of `3:22-26`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16217> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16217: check-api-annotations should check that an annotation does not precede its span -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by alanz): Merge request on gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/190 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16217#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16217: check-api-annotations should check that an annotation does not precede its span -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * milestone: => 8.8.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16217#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16217: check-api-annotations should check that an annotation does not precede its span -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: task | Status: new Priority: normal | Milestone: 8.8.1 Component: Test Suite | Version: 8.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"3cf12e6081e7a9f0c3d515de52ffd079186816a5/ghc" 3cf12e60/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="3cf12e6081e7a9f0c3d515de52ffd079186816a5" check-api-annotations checks for annotation preceding its span For an API annotation to be useful, it must not occur before the span it is enclosed in. So, for check-api-annotation output, a line such as ((Test16212.hs:3:22-36,AnnOpenP), [Test16212.hs:3:21]), should be flagged as an error, as the AnnOpenP location of 3:21 precedes its enclosing span of 3:22-26. This patch does this. Closes #16217 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16217#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC