[GHC] #10636: Clear up difference between `WayDyn` and `Opt_Static`
#10636: Clear up difference between `WayDyn` and `Opt_Static` -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- There are currently 2 different ways to test for a static or dynamic build: 1. Test if `WayDyn` is in `ways` 2. Test if `Opt_Static` is set Unless there's a use-case for setting `WayDyn`/`Opt_Static` inconsistently (if so, please add a `Note` somewhere), it should be possible to replace all queries of `Opt_Static` with an equivalent query of `WayDyn`. That would have prevented bug #8294. See the comments in Phab:D1017. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10636: Clear up difference between `WayDyn` and `Opt_Static` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * owner: => thomie Comment: Also (partially) causes #8294. This needs fixing. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10636: Clear up difference between `WayDyn` and `Opt_Static` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * cc: simonmar (added) Comment: Simon, perhaps you could shed some light why these two exist? I would imagine it is a historical accident but it would be good to know this for certain. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10636: Clear up difference between `WayDyn` and `Opt_Static` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"6d9c18cb43c1fda95932ef0f640dcf41906a2773/ghc" 6d9c18cb/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="6d9c18cb43c1fda95932ef0f640dcf41906a2773" DynFlags: remove Opt_Static There are currently 2 different ways to test for a static or dynamic build: * Test if WayDyn is in ways * Test if Opt_Static is set The problem is that these can easily go out of sync, especially when using the GHC API. This commit replaces all queries of Opt_Static with an equivalent query of WayDyn. This would have prevented bug #8294 and fixes #11154. Reviewers: hvr, austin, bgamari Reviewed By: austin, bgamari Differential Revision: https://phabricator.haskell.org/D1607 GHC Trac Issues: #10636 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10636: Clear up difference between `WayDyn` and `Opt_Static` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10636: Clear up difference between `WayDyn` and `Opt_Static` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonmar):
Simon, perhaps you could shed some light why these two exist? I would imagine it is a historical accident but it would be good to know this for certain.
I'm pretty sure it's a historical accident -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10636#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC