[GHC] #9084: Template Haskell should warn when it encounters an unencodable pragma
#9084: Template Haskell should warn when it encounters an unencodable pragma ------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: new Priority: normal | Milestone: Component: Template Haskell | Version: 7.8.2 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- When I say this {{{ {-# LANGUAGE TemplateHaskell #-} {-# OPTIONS_GHC -Wall #-} module Bug where $([d| class C a where meth :: a -> a meth = undefined -- give a (silly) default {-# MINIMAL meth #-} |]) instance C Int }}} I get no warnings. I'm not surprised that TH doesn't handle every pragma that GHC knows about, but it should issue a (suppressable) warning when it discards one. I can fix this one. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9084: Template Haskell should warn when it encounters an unencodable pragma -------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: new Priority: normal | Milestone: Component: Template | Version: 7.8.2 Haskell | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D388 | -------------------------------------+------------------------------------- Changes (by goldfire): * differential: => Phab:D388 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9084: Template Haskell should warn when it encounters an unencodable pragma -------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: new Priority: normal | Milestone: Component: Template | Version: 7.8.2 Haskell | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D388 | -------------------------------------+------------------------------------- Comment (by Richard Eisenberg <eir@…>): In [changeset:"17265c033707a84fd59fec61b3a370c3a427ffa3/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="17265c033707a84fd59fec61b3a370c3a427ffa3" Fix testsuite output from #9084. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9084: Template Haskell should warn when it encounters an unencodable pragma -------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: new Priority: normal | Milestone: Component: Template | Version: 7.8.2 Haskell | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D388 | -------------------------------------+------------------------------------- Comment (by Richard Eisenberg <eir@…>): In [changeset:"862772b7ecfce977ffe7090659da3bd923ef946a/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="862772b7ecfce977ffe7090659da3bd923ef946a" Test #9084 in th/T9084. The patch includes errors for a whole host of pragmas. But, these are generated one at a time, and it doesn't seem like a good idea to add gobs of test-cases here. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9084: Template Haskell should warn when it encounters an unencodable pragma -------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: new Priority: normal | Milestone: Component: Template | Version: 7.8.2 Haskell | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D388 | -------------------------------------+------------------------------------- Comment (by Richard Eisenberg <eir@…>): In [changeset:"03d61cce4d92a37a193cc1211eb7262149f22e3b/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="03d61cce4d92a37a193cc1211eb7262149f22e3b" Fix #9084 by calling notHandled when unknown bits are enountered. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9084: Template Haskell should warn when it encounters an unencodable pragma -------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: new Priority: normal | Milestone: Component: Template | Version: 7.8.2 Haskell | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D388 | -------------------------------------+------------------------------------- Comment (by Richard Eisenberg <eir@…>): In [changeset:"18a4a5dad3cbee3c8bb4005ec09edf401ebe294c/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="18a4a5dad3cbee3c8bb4005ec09edf401ebe294c" Update release notes for #9262 #8953 #9084. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9084: Template Haskell should warn when it encounters an unencodable pragma -------------------------------------+------------------------------------- Reporter: goldfire | Owner: goldfire Type: bug | Status: closed Priority: normal | Milestone: Component: Template | Version: 7.8.2 Haskell | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: th/T9084 | Blocking: | Differential Revisions: Phab:D388 | -------------------------------------+------------------------------------- Changes (by goldfire): * status: new => closed * testcase: => th/T9084 * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9084#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC