#15480: Rename SigTv -------------------------------------+------------------------------------- Reporter: nomeata | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.5 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- After #15050 and [changeset:"4d91cabcd5e3c603997d9876f6d30204a9b029c6/ghc" 4d91cabc/ghc] it seems odd to call `SigTv` for the kind of type variables that used to be used in type signatures in patterns, but are now used in other places (kind signatures, partial type signatures). Also, `SigTv` may be associated with sigma. At some point I assumed that `SigTv` are type variables that may unify with polytypes, while `TauTv` are those that unify with monotypes. As a service to our future self, I’d like to rename `SigTv`. Suggestions? Best one I have is `TvTv` or `TyVarTv` (for a type variable that stands for a type variable). -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15480> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15480: Rename SigTv -------------------------------------+------------------------------------- Reporter: nomeata | Owner: (none) Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonpj): Yes.... `TyVarTv` is probably best. It doesn't get used much so being a bit longer doesn't matter. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15480#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15480: Rename SigTv -------------------------------------+------------------------------------- Reporter: nomeata | Owner: (none) Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5074 Wiki Page: | -------------------------------------+------------------------------------- Changes (by nomeata): * status: new => patch * differential: => Phab:D5074 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15480#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15480: Rename SigTv -------------------------------------+------------------------------------- Reporter: nomeata | Owner: (none) Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5074 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Joachim Breitner <mail@…>): In [changeset:"a50244c6a87176a4df8d41e6a1a3f102ba129032/ghc" a50244c/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="a50244c6a87176a4df8d41e6a1a3f102ba129032" Rename SigTv to TyVarTv (#15480) because since #15050, these are no longer used in pattern SIGnatures, but still in other places where meta-variables should only be unified with TYpe VARiables. I also found mentions of `SigTv` in parts of the renamer and desugarer that do not seem to directly relate to `SigTv` as used in the type checker, but rather to uses of `forall a.` in type signatures. I renamed these to `ScopedTv`. Differential Revision: https://phabricator.haskell.org/D5074 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15480#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#15480: Rename SigTv -------------------------------------+------------------------------------- Reporter: nomeata | Owner: (none) Type: task | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 8.5 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5074 Wiki Page: | -------------------------------------+------------------------------------- Changes (by nomeata): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15480#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC