[GHC] #9758: By default, testsuite should clean up after successful tests
#9758: By default, testsuite should clean up after successful tests -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: task | Status: new Priority: low | Milestone: Component: Test Suite | Version: 7.9 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- A fully built GHC compiler for development takes about 1G of space. However, running the testsuite balloons this amount to 10G. Why? Because we don't clear away any test files by default. Now, it's pretty useful to have these files if you're debugging a problem. But I think it's pretty unnecessary for successful tests. So I suggest cleaning out the files automatically if the test succeeds. Tradeoff: the testsuite will take longer to run since it is cleaning up after itself. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9758 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9758: By default, testsuite should clean up after successful tests -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: task | Status: new Priority: low | Milestone: Component: Test Suite | Version: 7.9 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by hvr): I'm not sure what you mean... if you look at the top-level Makefile, the `test` targets (which are also used by `./validate`) already cleanup by default: {{{#!make .PHONY: test test: $(MAKE) -C testsuite/tests CLEANUP=1 OUTPUT_SUMMARY=../../testsuite_summary.txt fast .PHONY: fulltest fulltest: $(MAKE) -C testsuite/tests CLEANUP=1 OUTPUT_SUMMARY=../../testsuite_summary.txt }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9758#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9758: By default, testsuite should clean up after successful tests -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: task | Status: new Priority: low | Milestone: Component: Test Suite | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by nomeata): I often run `make test` in the `testsuite/tests` directory itself, and this this bytes. I suggest to simply make `CLEANUP=1` the default, and if someone needs to build an individual test _and keep the output_ (which I expect is the exception), then have him say `CLEANUP=0` explicitly. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9758#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9758: By default, testsuite should clean up after successful tests -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: task | Status: patch Priority: low | Milestone: 8.2.1 Component: Test Suite | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2148 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => patch * differential: => Phab:D2148 * milestone: => 8.2.1 Comment:
I suggest to simply make `CLEANUP=1` the default
Yes, let's do this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9758#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9758: By default, testsuite should clean up after successful tests
-------------------------------------+-------------------------------------
Reporter: ezyang | Owner:
Type: task | Status: patch
Priority: low | Milestone: 8.2.1
Component: Test Suite | Version: 7.9
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D2148
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Thomas Miedema
#9758: By default, testsuite should clean up after successful tests -------------------------------------+------------------------------------- Reporter: ezyang | Owner: Type: task | Status: closed Priority: low | Milestone: 8.2.1 Component: Test Suite | Version: 7.9 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2148 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9758#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC