[GHC] #14656: Nofib: Ignore cr-lineendings in benchmarks
#14656: Nofib: Ignore cr-lineendings in benchmarks -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: NoFib | Version: 8.2.2 benchmark suite | Keywords: | Operating System: Windows Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- At least the real/eff benchmarks fail because of this. {{{ ==nofib== CS: time to run CS follows... ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc-timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc-timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; real 0m0.173s user 0m0.000s sys 0m0.015s ././CS < /dev/null expected stdout not matched by reality <<ghc: 640047168 bytes, 611 GCs (609 + 2), 0/0 avg/max bytes residency (0 samples), 290232 bytes GC work, 2M in use, 0.000 INIT (0.000 elapsed), 0.125 MUT (0.124 elapsed), 0.000 GC (0.001 elapsed), 0.000 GC(0) (0.001 elapsed), 0.000 GC(1) (0.001 elapsed), 1 balance :ghc>> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14656> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14656: Nofib: Ignore cr-lineendings in benchmarks -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: NoFib benchmark | Version: 8.2.2 suite | Resolution: | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Description changed by AndreasK: Old description:
At least the real/eff benchmarks fail because of this.
{{{ ==nofib== CS: time to run CS follows... ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc-timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc-timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ;
real 0m0.173s user 0m0.000s sys 0m0.015s ././CS < /dev/null expected stdout not matched by reality <<ghc: 640047168 bytes, 611 GCs (609 + 2), 0/0 avg/max bytes residency (0 samples), 290232 bytes GC work, 2M in use, 0.000 INIT (0.000 elapsed), 0.125 MUT (0.124 elapsed), 0.000 GC (0.001 elapsed), 0.000 GC(0) (0.001 elapsed), 0.000 GC(1) (0.001 elapsed), 1 balance :ghc>> }}}
New description: At least the real/eff benchmarks fail because of this on Windows. {{{ ==nofib== CS: time to run CS follows... ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc-timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc-timing -stdout-binary ; ../../../runstdtest/runstdtest ./CS -o1 CS.stdout -o1 CS.stdout -ghc- timing -stdout-binary ; real 0m0.173s user 0m0.000s sys 0m0.015s ././CS < /dev/null expected stdout not matched by reality <<ghc: 640047168 bytes, 611 GCs (609 + 2), 0/0 avg/max bytes residency (0 samples), 290232 bytes GC work, 2M in use, 0.000 INIT (0.000 elapsed), 0.125 MUT (0.124 elapsed), 0.000 GC (0.001 elapsed), 0.000 GC(0) (0.001 elapsed), 0.000 GC(1) (0.001 elapsed), 1 balance :ghc>> }}} -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14656#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14656: Nofib: Ignore cr-lineendings in benchmarks -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: NoFib benchmark | Version: 8.2.2 suite | Resolution: | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4705 Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * status: new => patch * differential: => Phab:D4705 Comment: Came across the cause by chance today. Their Makefiles marked the benchmark results as binary data instead of text. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14656#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14656: Nofib: Ignore cr-lineendings in benchmarks -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: NoFib benchmark | Version: 8.2.2 suite | Resolution: | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4705 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"3ef116aa7ed572b8ee32223a18bce8d61a635b02/nofib" 3ef116a/nofib]: {{{ #!CommitTicketReference repository="nofib" revision="3ef116aa7ed572b8ee32223a18bce8d61a635b02" Don't use binary output for real/eff. These use putStrLn so clearly we are not producing binary data. This caused failures on windows. Reviewers: O26 nofib, bgamari Reviewed By: bgamari Subscribers: bgamari GHC Trac Issues: #14656 Differential Revision: https://phabricator.haskell.org/D4705 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14656#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14656: Nofib: Ignore cr-lineendings in benchmarks -------------------------------------+------------------------------------- Reporter: AndreasK | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: NoFib benchmark | Version: 8.2.2 suite | Resolution: fixed | Keywords: Operating System: Windows | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4705 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.6.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14656#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC