[GHC] #13899: Improve [-Wmissing-home-modules] error message
#13899: Improve [-Wmissing-home-modules] error message -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- At the moment when this warning is triggered, GHC emits something like {{{#!hs <no location info>: warning: [-Wmissing-home-modules] Modules are not listed in command line: Language.Haskell.GHC.ExactPrint }}} It is not clear that this is actually reporting a problem in the cabal file which has incomplete "other-modules" for one or other target. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13899 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13899: Improve [-Wmissing-home-modules] error message -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by hvr): As `-Wmissing-home-modules` is a generic warning message we may want to avoid mentioning `other-extensions` unless we're actually building via Cabal. So here's an example from `GhcMake.hs` which changes the compiler message based on the presence of the `-fcabal-building-package` flag: {{{#!hs in throwOneError $ mkPlainErrMsg dflags' mod_loc $ text "Unexpected signature:" <+> quotes (ppr mod_name) $$ if gopt Opt_BuildingCabalPackage dflags then parens (text "Try adding" <+> quotes (ppr mod_name) <+> text "to the" <+> quotes (text "signatures") <+> text "field in your Cabal file.") else parens (text "Try passing -instantiated-with=\"" <> suggested_instantiated_with <> text "\"" $$ text "replacing <" <> ppr mod_name <> text "> as necessary.") }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13899#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13899: Improve [-Wmissing-home-modules] error message -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3686 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3686 Comment: See Phab:D3686. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13899#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13899: Improve [-Wmissing-home-modules] error message
-------------------------------------+-------------------------------------
Reporter: alanz | Owner: (none)
Type: bug | Status: patch
Priority: normal | Milestone: 8.2.1
Component: Compiler | Version: 8.2.1-rc2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D3686
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#13899: Improve [-Wmissing-home-modules] error message -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3686 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13899#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13899: Improve [-Wmissing-home-modules] error message -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.2.1-rc2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3686 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Merged to `ghc-8.2` in 17bce7bccbc65058dc064acf1ef38a5466491c76. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13899#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC