[GHC] #11071: The "Not in scope" error is misleading

older
[GHC] #10168: generalize filterM,...

GHC

8 Nov 2015 8 Nov '15

8:16 a.m.

#11071: The "Not in scope" error is misleading -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- E.g., if I have something like `Maybe.maybeToList` in a module, which does not have such an import, I get the following error: Not in scope: ‘Maybe.maybeToList’ Which leads the user to conclude that the `Maybe` namespace does not contain the `maybeToList` element, instead of informing that the `Maybe` namespace is not imported altogether instead. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Show replies by date

GHC

8 Nov 8 Nov

1:09 p.m.

#11071: The "Not in scope" error is misleading -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): I don't understand why would anyone conclude from this message: {{{ Not in scope: NameSpace.name }}} that the namespace doesn't define the name. The message doesn't say anything about something being defined or not, it's very clearly saying that the name is not in scope. It may be because of different reasons. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

1:14 p.m.

#11071: The "Not in scope" error is misleading -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mojojojo): Reference to a specific member implies that that particular member is the problem, while in reality it is the absence of the whole namespace that is the problem. In no way does the current message suggest that. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

1:31 p.m.

...

while in reality it is the absence of the whole namespace that is the

#11071: The "Not in scope" error is misleading -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by jstolarek): Replying to [comment:2 mojojojo]: problem I disagree. If you have: ``` import Foo hiding ( bar ) ``` then `Foo` namespace is available, but any reference to `bar` will still result with "not in scope" error. I find the error message entirely correct and vote to close this ticket as "invalid". -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

2:13 p.m.

#11071: The "Not in scope" error is misleading -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mojojojo): Replying to [comment:3 jstolarek]: You're missing the point here. The issue is that the message does not make sense specifically when the namespace is **not imported in any way**. It misleads the user to assume that it is imported but does not contain the member (or has it hidden), when the issue is absolutely different. Your example is simply not related to the issue. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

5:39 p.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names. (was: The "Not in scope" error is misleading)

#11071: "Not in scope" errors should be more informative for qualified names. -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by nomeata): * type: bug => feature request Comment: No need to get excited. We have a track of giving rather verbose error messages that try to convey as much information as possible to the user. So simply add any useful additional information, such as: {{{ Not in scope: ‘Maybe.maybeToList’ No Module named Maybe is imported. }}} or {{{ Not in scope: ‘Maybe.maybeToList’ Module `Maybe` does not provide `maybeToList` }}} or {{{ Not in scope: ‘Maybe.maybeToList’ Your import of `Maybe` explicitly hides `maybeToList`. }}} for the three cases I can think of why some `Foo.bar` is not in scope. This would indeed be useful, and helpful in any case. It’s also not completely trivial, as there is a many-to-many mapping of modules and modules name in scope, due to qualified imports. Nevertheless, this looks like a nice newcomer task. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

9 Nov 9 Nov

6:16 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

GHC

6:31 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

GHC

10 Nov 10 Nov

11:05 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

...

E.g., if I have something like `Maybe.maybeToList` in a module, which does not have such an import, I get the following error:

Not in scope: ‘Maybe.maybeToList’

Which leads the user to conclude that the `Maybe` namespace does not contain the `maybeToList` element, instead of informing that the `Maybe` namespace is not imported altogether instead.

New description: E.g., if I have something like `Maybe.maybeToList` in a module, which does not have such an import, I get the following error: Not in scope: ‘Maybe.maybeToList’ Which leads the user to conclude that the `Maybe` namespace does not contain the `maybeToList` element, instead of informing that the `Maybe` namespace is not imported altogether instead -- Comment: Looking at the code right now. The first case (`No Module named Maybe is imported.`) is pretty easy. The other cases are actually quite tricky. The semantics of import lists is rather involved, and the code in `filterImports` in `RnNames` is quite terse. Maybe it is better to simply remember the `mi_exports` of all modules, look up the name there, and if it is found, then conclude that it was the fault of the import list. OTOH, a perfect solution would actually suggest to add `D3` to the `C(D1,D2,D3)` in `import Foo (C(D1,D2))` if a data constructor `Foo.D3` is out of scope. I’ll see how far I get... -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

11 Nov 11 Nov

7:05 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

GHC

12 Nov 12 Nov

9:12 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

#11071: "Not in scope" errors should be more informative for qualified names. -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: nomeata Type: feature request | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1462 Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): Looking at the code, it doesn't seem too difficult to also improve the error message for cases (3) and (4) (from comment:5) when using //unqualified// imports. For example: {{{ import Data.Map import Data.List hiding (transpose) f = transpose }}} This could show the same message as when `f = Data.List.transpose`: `"Perhaps you want to remove ‘transpose’ from the explicit hiding list in the import of ‘Data.List’"`, because only `Data.List` exports `transpose`; `Data.Map` doesn't. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

9:31 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

GHC

13 Nov 13 Nov

4:14 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

#11071: "Not in scope" errors should be more informative for qualified names. -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: nomeata Type: feature request | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1462 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Joachim Breitner ): In [changeset:"e66f79dfb22031dd3f75dd3eb341e8269ab51d83/ghc" e66f79df/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="e66f79dfb22031dd3f75dd3eb341e8269ab51d83" Give helpful advice when a fully qualified name is not in scope This implements #11071. It needs to thread through a GlobalRdrEnv corresponding to the export list of the module if its exports were not restricted. A refactoring of ImportedModsVal into a proper data type follows. Differential Revision: https://phabricator.haskell.org/D1462 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

4:26 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

#11071: "Not in scope" errors should be more informative for qualified names. -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: nomeata Type: feature request | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1462 Wiki Page: | -------------------------------------+------------------------------------- Comment (by nomeata): First version landed. I’ll leave this open to implement thomie’s suggestions (which will necessarily include a special case for this: {{{ foo is not in scope. You have not imported anything, not even Prelude. You are on your own! }}} (The more common, new cases will be: Printing nothing if no restricted import exists or no restricted import exports `foo`, and the usual list from above if one or more restricted unqualified import could be made to provide `foo`.) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

15 Nov 15 Nov

3:26 p.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

GHC

18 Nov 18 Nov

6:53 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

#11071: "Not in scope" errors should be more informative for qualified names. -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: nomeata Type: feature request | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1462 Wiki Page: | Phab:D1478 -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"11e336e4a4f7a0c0319d9bfb1a6931a5861299cf/ghc" 11e336e4/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="11e336e4a4f7a0c0319d9bfb1a6931a5861299cf" More import related hints Now for unqualified imports. Improves upon #11071. Unfortunately, it seems that since 7.10, ghc will not print all out-of-scope errors. Test Plan: test suite updated Reviewers: austin, thomie, bgamari Reviewed By: bgamari Differential Revision: https://phabricator.haskell.org/D1478 GHC Trac Issues: #11071 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

7:19 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

GHC

8:57 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

...

Thomie, how do you like Phab:D1478?

Perfect. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:17 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

19 Nov 19 Nov

6:29 a.m.

New subject: [GHC] #11071: "Not in scope" errors should be more informative for qualified names.

#11071: "Not in scope" errors should be more informative for qualified names. -------------------------------------+------------------------------------- Reporter: mojojojo | Owner: nomeata Type: feature request | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1462 Wiki Page: | Phab:D1478 -------------------------------------+------------------------------------- Comment (by Joachim Breitner ): In [changeset:"a586622c5386610e8ceffca7ef1efdf33d753587/ghc" a586622c/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="a586622c5386610e8ceffca7ef1efdf33d753587" Release Notes: Mention out-of-scope error message improvements Summary: as implemented for #11071. Differential Revision: https://phabricator.haskell.org/D1498 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11071#comment:18 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

3473

Age (days ago)

3484

Last active (days ago)

List overview

Download

18 comments

1 participants

[GHC] #11071: The "Not in scope" error is misleading

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

tags

participants (1)