[GHC] #10485: Remove __MINGW32__ from all source files
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Keywords: newcomer | Operating System: Windows Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- See ticket:9945#comment:15. Prepare a patch that removes all occurrences of `__MINGW32__` from all source files, and send it to [wiki:Phabricator]. Easy! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by Berdes): * owner: => Berdes -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Berdes): Hello, I'm new to the project and I would like to make this task. I have found many files where {{{__MINGW32__}}} appears. Two of them are on utils and the others are on libraries. Since some of them are under sub-repositories (libraries/filepath for exemple), I'm not able to include them on a commit. What should I do? Note : I've never worked with sub-repositories, so I may have missed something. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: infoneeded Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by Berdes): * status: new => infoneeded -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by thomie): * status: infoneeded => new Comment: Only do the ones in the main repository. The libraries are mostly maintained by others. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D971 -------------------------------------+------------------------------------- Changes (by Berdes): * status: new => patch * differential: => Phab:D971 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D971 -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"0db0ac4a255931036c5859c3f22108f4e27ccd11/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="0db0ac4a255931036c5859c3f22108f4e27ccd11" Removes all occurrences of __MINGW32__ (#10485) In Haskell files, replace `__MINGW32__` by `mingw32_HOST_OS`. In .c and .h files, delete `__MINGW32__` when `_WIN32` is also tested because `_WIN32` is always defined when `__MINGW32__` is. Also replace `__MINGW32__` by `_WIN32` when used standalone for consistency. Differential Revision: https://phabricator.haskell.org/D971 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10485: Remove __MINGW32__ from all source files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Berdes Type: task | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: newcomer Operating System: Windows | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D971 -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => closed * resolution: => fixed Comment: Sorry, for some reason this patch didn't get your name on it. It should have! So for the record: {{{ This patch was authored by Bernard Desmyter. }}} Thanks. See you in #10511. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10485#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC