[GHC] #7591: CodeGen.Platform.hs not including ghcautoconf.h as it should, breaks ARMv5 compiler
#7591: CodeGen.Platform.hs not including ghcautoconf.h as it should, breaks ARMv5 compiler --------------------------------+------------------------------------------- Reporter: StephenBlackheath | Owner: Type: bug | Status: new Priority: normal | Component: Compiler Version: 7.7 | Keywords: arm cross llvm Os: Unknown/Multiple | Architecture: arm Failure: Building GHC failed | Blockedby: Blocking: | Related: --------------------------------+------------------------------------------- MachRegs.h requires ghcautoconf.h to be included before it, because, in the case of ARM processors, it needs to know what ARM variant is being used. This patch fixes that in includes/CodeGen.Platform.hs, otherwise there is a mismatch between the compiler and llvm. Perhaps it needs to be made more robust by instead including ghcautoconf.h from MachRegs.h? Otherwise someone else could easily break it. I originally didn't do this, because it wasn't done anywhere else. Suggested fix attached. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7591 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#7591: CodeGen.Platform.hs not including ghcautoconf.h as it should, breaks ARMv5 compiler ----------------------------------+----------------------------------------- Reporter: StephenBlackheath | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.7 Keywords: arm cross llvm | Os: Unknown/Multiple Architecture: arm | Failure: Building GHC failed Difficulty: Unknown | Testcase: Blockedby: | Blocking: 7623 Related: | ----------------------------------+----------------------------------------- Changes (by igloo): * status: new => patch * difficulty: => Unknown -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7591#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#7591: CodeGen.Platform.hs not including ghcautoconf.h as it should, breaks ARMv5
compiler
----------------------------------+-----------------------------------------
Reporter: StephenBlackheath | Owner:
Type: bug | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 7.7
Keywords: arm cross llvm | Os: Unknown/Multiple
Architecture: arm | Failure: Building GHC failed
Difficulty: Unknown | Testcase:
Blockedby: | Blocking: 7623
Related: |
----------------------------------+-----------------------------------------
Comment(by docks.cattlemen.stephen@…):
commit 8bb9548a991142137d13a8d77fb6f46ed2f49f4d
{{{
Author: Stephen Blackheath
#7591: CodeGen.Platform.hs not including ghcautoconf.h as it should, breaks ARMv5 compiler ----------------------------------+----------------------------------------- Reporter: StephenBlackheath | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.7 Resolution: fixed | Keywords: arm cross llvm Os: Unknown/Multiple | Architecture: arm Failure: Building GHC failed | Difficulty: Unknown Testcase: | Blockedby: Blocking: 7623 | Related: ----------------------------------+----------------------------------------- Changes (by simonmar): * status: patch => closed * resolution: => fixed Comment: Thanks for the patch! -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7591#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC