[GHC] #11965: USE_PTHREAD_FOR_ITIMER causes unnecessary wake-ups
#11965: USE_PTHREAD_FOR_ITIMER causes unnecessary wake-ups -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: high | Milestone: Component: Runtime | Version: 7.10.3 System | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Runtime Unknown/Multiple | performance bug Test Case: | Blocked By: Blocking: | Related Tickets: #1623 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The `USE_PTHREAD_FOR_ITIMER` path appears to regress #1623 as it has no ability to disarm the timer when the ticker is in the `STOPPED` state. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11965> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11965: USE_PTHREAD_FOR_ITIMER causes unnecessary wake-ups -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: patch Priority: high | Milestone: Component: Runtime System | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: #1623 | Differential Rev(s): Phab:D2131 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D2131 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11965#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11965: USE_PTHREAD_FOR_ITIMER causes unnecessary wake-ups -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: patch Priority: high | Milestone: Component: Runtime System | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: #1623 | Differential Rev(s): Phab:D2131 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"999c464da36e925bd4ffea34c94d3a7b3ab0135c/ghc" 999c464/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="999c464da36e925bd4ffea34c94d3a7b3ab0135c" rts/itimer/pthread: Stop timer when ticker is stopped This reworks the pthread-based itimer implementation to disarm the timer when events aren't needed. Thanks to hsyl20 for the nice design. Test Plan: Validate Reviewers: hsyl20, simonmar, austin Reviewed By: simonmar Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2131 GHC Trac Issues: #1623, #11965 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11965#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11965: USE_PTHREAD_FOR_ITIMER causes unnecessary wake-ups -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: closed Priority: high | Milestone: 8.2.1 Component: Runtime System | Version: 7.10.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: #1623 | Differential Rev(s): Phab:D2131 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.2.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11965#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC