[GHC] #12691: Refine the behaviour of -dno-debug-output and -dtrace-level
#12691: Refine the behaviour of -dno-debug-output and -dtrace-level -------------------------------------+------------------------------------- Reporter: mpickering | Owner: Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- It wasn't clear to me what these flags should do and what they should turn off. From the user guide. `-dno-debug-output`:: Suppress any unsolicited debugging output. When GHC has been built with the DEBUG option it occasionally emits debug output of interest to developers. The extra output can confuse the testing framework and cause bogus test failures, so this flag is provided to turn it off. `-dtrace-level`:: Not present `-dno-debug-output` currently suppresses the output of `-ddump-tc-trace` which is certainly not "unsolicited". It should be used, and is, in `Outputable` to suppress the output of `pprTrace`. `dtrace-level` is used in a few places but always as if was a boolean flag. I don't really see what the point of it is. The only commit which mentions it is "8cdb98b9909561671ab4e61c90ebb12504478e4d" and I can't find the origin of the flag. I think we should just remove it. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12691> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12691: Refine the behaviour of -dno-debug-output and -dtrace-level -------------------------------------+------------------------------------- Reporter: mpickering | Owner: Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonpj): I rather agree with all this. I think the trace-level thing was intended to allow different levels of trace verbosity, but it never got properly used. OK to remove it. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12691#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12691: Refine the behaviour of -dno-debug-output and -dtrace-level -------------------------------------+------------------------------------- Reporter: mpickering | Owner: Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"48876ae04c4963f8d5a60a121ac85d52322faaee/ghc" 48876ae/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="48876ae04c4963f8d5a60a121ac85d52322faaee" Remove -dtrace-level The flag was: 1. Not documented. 2. Only used as a boolean flag. 3. Has overlapping functionality with -dno-debug-output 4. My poll of #ghc concluded that people didn't know it existed. Reviewers: austin, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2627 GHC Trac Issues: #12691 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12691#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12691: Refine the behaviour of -dno-debug-output and -dtrace-level -------------------------------------+------------------------------------- Reporter: mpickering | Owner: Type: task | Status: closed Priority: low | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.2.1 Comment: I'm going to leave this out of 8.0.2 since it only affects compiler debugging functionality. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12691#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12691: Refine the behaviour of -dno-debug-output and -dtrace-level -------------------------------------+------------------------------------- Reporter: mpickering | Owner: Type: task | Status: closed Priority: low | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Matthew Pickering <matthewtpickering@…>): In [changeset:"1c886eadcfbb593bb06bfff7b8a4914b5349f080/ghc" 1c886ea/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="1c886eadcfbb593bb06bfff7b8a4914b5349f080" Stop -dno-debug-output suppressing -ddump-tc-trace Summary: The user manual states that -dno-debug-output should suppress *unsolicited* debugging output which essentially amounts to calls to `pprTrace`. Before I unified the interface of `traceTc` and `traceRn`, the flag suppressed calls to `traceTc` but not to `traceRn` or any other tracing function already controlled by a flag. Thus, in order to make the behaviour more uniform, it seemed best to remove this one special case. Reviewers: austin, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2628 GHC Trac Issues: #12691 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12691#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC