#16015: git notes logic breaks CircleCI validation of pull requests -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: highest | Milestone: 8.6.3 Component: Compiler | Version: 8.6.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by davide): @bgamari, when we originally set up CircleCI to push git notes, you had to configure CircleCI with the correct ssh key. It looks to me like this ssh key is not used when CI runs for PRs (hence missing credentials). I don't have access to ghc's CircleCI configuration, so I can only speculate. Perhaps you set up the key to be used only on a specific host and CI for PRs are run on a different host? This also begs the question: do we want to push performance notes for PRs, or only for merged commits (I would guess only merged commits)? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16015#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#16015: git notes logic breaks CircleCI validation of pull requests -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: highest | Milestone: Component: Compiler | Version: 8.6.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16015#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler