[GHC] #8483: Use addDependentFile in Language.Haskell.TH.Syntax.quoteFile
#8483: Use addDependentFile in Language.Haskell.TH.Syntax.quoteFile -------------------------------------+------------------------------------- Reporter: aavogt | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: libraries (other) | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: None/Unknown Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- Users should expect ghc to recompile when those files change. Also the documentation should reflect that no spaces are stripped from the filename. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8483 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8483: Use addDependentFile in Language.Haskell.TH.Syntax.quoteFile --------------------------------------+------------------------------------ Reporter: aavogt | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: libraries (other) | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Changes (by monoidal): * status: new => patch Comment: Hm. Generally looks good, but do you know whether there's an issue with relative paths? See http://stackoverflow.com/questions/16163948. If this is not a problem, I'll commit. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8483#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8483: Use addDependentFile in Language.Haskell.TH.Syntax.quoteFile --------------------------------------+------------------------------------ Reporter: aavogt | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: libraries (other) | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by aavogt): I think there is no problem. You get a listing of the directory you call ghc from here: {{{ {-# LANGUAGE TemplateHaskell #-} import Language.Haskell.TH import System.Cmd do runIO (system "ls") [d| () = () |] }}} If `addDependentFile` also looks relative to the path ghc is called from, then it seems like you will only have one file referenced using my patch. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8483#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8483: Use addDependentFile in Language.Haskell.TH.Syntax.quoteFile --------------------------------------+------------------------------------ Reporter: aavogt | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: libraries (other) | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged, thanks! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8483#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC