[GHC] #16265: API Annotations: parens anns discarded for `(*)` operator
#16265: API Annotations: parens anns discarded for `(*)` operator -------------------------------------+------------------------------------- Reporter: alanz | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 (Parser) | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect API Unknown/Multiple | annotation Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The patch from https://phabricator.haskell.org/D4865 introduces {{{#!hs go _ (HsParTy _ (dL->L l (HsStarTy _ isUni))) acc ann fix = do { warnStarBndr l ; let name = mkOccName tcClsName (if isUni then "★" else "*") ; return (cL l (Unqual name), acc, fix, ann) } }}} which discards the parens annotations belonging to the `HsParTy`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16265> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16265: API Annotations: parens anns discarded for `(*)` operator -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * owner: (none) => alanz -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16265#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16265: API Annotations: parens anns discarded for `(*)` operator -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by alanz): gitlab MR is https://gitlab.haskell.org/ghc/ghc/merge_requests/278 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16265#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16265: API Annotations: parens anns discarded for `(*)` operator -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: merge Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by alanz): * status: new => merge Comment: This has landed in master as https://gitlab.haskell.org/ghc/ghc/commit/5e9888bd9c22a1315a703f638591b50e65... -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16265#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#16265: API Annotations: parens anns discarded for `(*)` operator -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: merge Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.6.3 (Parser) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect API | Unknown/Multiple annotation | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Marge Bot <ben+marge-bot@…>): In [changeset:"5e9888bd9c22a1315a703f638591b50e657317c4/ghc" 5e9888b/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="5e9888bd9c22a1315a703f638591b50e657317c4" API Annotations: parens anns discarded for `(*)` operator The patch from https://phabricator.haskell.org/D4865 introduces go _ (HsParTy _ (dL->L l (HsStarTy _ isUni))) acc ann fix = do { warnStarBndr l ; let name = mkOccName tcClsName (if isUni then "★" else "*") ; return (cL l (Unqual name), acc, fix, ann) } which discards the parens annotations belonging to the HsParTy. Updates haddock submodule Closes #16265 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16265#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC