[GHC] #9325: mod73 output file needs to be reordered
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Keywords: mod73 | Differential Revisions: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect result | Unknown/Multiple at runtime | Difficulty: Unknown Test Case: mod73 | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------- The correct output from the mod73 test needs to be reordered in HEAD: {{{ =====> mod73(normal) 1610 of 4044 [0, 0, 0] cd ./module && '/Users/jrp/Projects/ghc/inplace/bin/ghc-stage2' -fforce- recomp -dcore-lint -dcmm-lint -dno-debug-output -no-user-package-db -rtsopts -fno-ghci-history -c mod73.hs >mod73.comp.stderr 2>&1 Actual stderr output differs from expected: --- ./module/mod73.stderr 2014-07-16 21:21:57.000000000 +0100 +++ ./module/mod73.comp.stderr 2014-07-17 20:15:54.000000000 +0100 @@ -2,6 +2,6 @@ mod73.hs:3:7: Not in scope: ‘Prelude.g’ Perhaps you meant one of these: - data constructor ‘Prelude.LT’ (imported from Prelude), + data constructor ‘Prelude.GT’ (imported from Prelude), data constructor ‘Prelude.EQ’ (imported from Prelude), - data constructor ‘Prelude.GT’ (imported from Prelude) + data constructor ‘Prelude.LT’ (imported from Prelude) *** unexpected failure for mod73(normal) Unexpected results from: TEST="mod73" }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: | Keywords: mod73 Differential Revisions: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect result Unknown/Multiple | at runtime Difficulty: Unknown | Test Case: mod73 Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- Comment (by rwbarton): Curiously my ''stage1'' compiler output matches the `mod73.stderr` file! What is going on here? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: | Keywords: mod73 Differential Revisions: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect result Unknown/Multiple | at runtime Difficulty: Unknown | Test Case: mod73 Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- Comment (by jrp): mod73 works again for me against the current head. Either someone fixed the issue my build system had some cruft from. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: | Keywords: mod73 Differential Revisions: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect result Unknown/Multiple | at runtime Difficulty: Unknown | Test Case: mod73 Blocked By: | Blocking: Related Tickets: | -------------------------------------+------------------------------------- Comment (by simonpj): The error message contains a list of suggested alternatives for an out of scope identifier. GHC makes no attempt to order this list in a canonical way, so it's not too surprising if the output wobble. Perhaps the test should do `wc` or something, or do its own sort on the output, to normalise? Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: | Keywords: mod73 Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: Test Case: mod73 | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by rwbarton): I agree that there's no reason why one version of the compiler should produce the same ordered list as the next version, but isn't it a bit odd that the stage1 and stage2 builds of the same compiler would give different output? That suggests a change in semantics of a function in base or something of that sort, doesn't it? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: | Keywords: mod73 Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: Test Case: mod73 | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by rwbarton): Compilers built with `-O` match the current `mod73.stderr` order and compilers built with `-O0` match the order proposed in this ticket. Given that the order depends on the ids of `FastString`s, I guess this isn't necessarily cause for alarm, though I don't have a specific explanation for it. ezyang added support for custom output checkers in f8e12e2b396e0c475e1403ab8ac3fc4d63c1681e, so for now we can configure the test to allow either output. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered
-------------------------------------+-------------------------------------
Reporter: jrp | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Test Suite | Version: 7.8.3
Resolution: | Keywords: mod73
Operating System: | Architecture: Unknown/Multiple
Unknown/Multiple | Difficulty: Unknown
Type of failure: Incorrect | Blocked By:
result at runtime | Related Tickets:
Test Case: mod73 |
Blocking: |
Differential Revisions: |
-------------------------------------+-------------------------------------
Comment (by Reid Barton
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: fixed | Keywords: mod73 Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: Test Case: mod73 | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by rwbarton): * status: new => closed * resolution: => fixed Comment: I found that I could use a custom stderr normaliser instead. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
ghci044.run.stdout 2>ghci044.run.stderr Actual stdout output differs from expected: --- /dev/null 2014-07-31 19:25:24.000000000 +0100 +++ ./ghci/scripts/ghci044.run.stdout 2014-07-31 19:25:24.000000000 +0100 @@ -0,0 +1,3 @@ +"First" +"First" +"First" *** unexpected failure for ghci044(ghci) =====> T4801(normal) 2001 of 4062 [0, 1, 0] cd ./perf/compiler && '/Users/jrp/Projects/haskell/ghc/inplace/bin/ghc- stage2' -fforce-recomp -dno-debug-output -no-user-package-db -rtsopts -fno-ghci-history -c T4801.hs +RTS -V0 -tT4801.comp.stats --machine- readable -RTS -static >T4801.comp.stderr 2>&1 max_bytes_used value is too high: Expected T4801(normal) max_bytes_used: 25145320 +/-5% Lower bound T4801(normal) max_bytes_used: 23888054 Upper bound T4801(normal) max_bytes_used: 26402586 Actual T4801(normal) max_bytes_used: 26679688 Deviation T4801(normal) max_bytes_used: 6.1 %
#9325: mod73 output file needs to be reordered
-------------------------------------+-------------------------------------
Reporter: jrp | Owner:
Type: bug | Status: closed
Priority: normal | Milestone:
Component: Test Suite | Version: 7.8.3
Resolution: fixed | Keywords: mod73
Operating System: | Architecture: Unknown/Multiple
Unknown/Multiple | Difficulty: Unknown
Type of failure: Incorrect | Blocked By:
result at runtime | Related Tickets:
Test Case: mod73 |
Blocking: |
Differential Revisions: |
-------------------------------------+-------------------------------------
Comment (by jrp):
Not sure whether it was this patch that caused the issue, but from today's
head I get:
{{{
=====> ghci044(ghci) 994 of 4062 [0, 0, 0]
cd ./ghci/scripts && HC='/Users/jrp/Projects/haskell/ghc/inplace/bin/ghc-
stage2' HC_OPTS='-dcore-lint -dcmm-lint -dno-debug-output -no-user-
package-db -rtsopts -fno-ghci-history '
'/Users/jrp/Projects/haskell/ghc/inplace/bin/ghc-stage2' --interactive -v0
-ignore-dot-ghci -dcore-lint -dcmm-lint -dno-debug-output -no-user-
package-db -rtsopts -fno-ghci-history
T9203.comp.stderr 2>&1 cd ./perf/should_run && ./T9203 +RTS -V0 -tT9203.stats --machine-readable -RTS T9203.run.stdout 2>T9203.run.stderr bytes allocated value is too low: (If this is because you have improved GHC, please update the test so that GHC doesn't regress again) Expected T9203(normal) bytes allocated: 95747304 +/-5% Lower bound T9203(normal) bytes allocated: 90959938 Upper bound T9203(normal) bytes allocated: 100534670 Actual T9203(normal) bytes allocated: 42946176 Deviation T9203(normal) bytes allocated: -55.1 % *** unexpected failure for T9203(normal) =====> T5435_dyn_asm(normal) 2491 of 4062 [0, 4, 0] cd ./rts && $MAKE -s --no-print-directory T5435_dyn_asm T5435_dyn_asm.run.stderr T5435_dyn_asm failed with ['modInitFunc1', 'modInitFunc2', 'success'], see all.T for details *** unexpected failure for T5435_dyn_asm(normal)
Unexpected results from: TEST="T9203 T5435_dyn_asm ghci044 haddock.base T4801" OVERALL SUMMARY for test run started at Thu Jul 31 19:25:23 2014 BST 0:00:05 spent to go through 4062 total tests, which gave rise to 19508 test cases, of which 19503 were skipped 0 had missing libraries 0 expected passes 0 expected failures 0 caused framework failures 0 unexpected passes 5 unexpected failures Unexpected failures: ghci/scripts ghci044 [bad stdout] (ghci) perf/compiler T4801 [stat too good] (normal) perf/haddock haddock.base [stat not good enough] (normal) perf/should_run T9203 [stat too good] (normal) rts T5435_dyn_asm [bad stdout] (normal) }}} This is with BuildFlavour = perf on a Mac. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9325: mod73 output file needs to be reordered -------------------------------------+------------------------------------- Reporter: jrp | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Test Suite | Version: 7.8.3 Resolution: fixed | Keywords: mod73 Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: Test Case: mod73 | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by simonpj): ghci044 is my fault, will fix. I don't know about the others. Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9325#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC