[GHC] #10277: ApiAnnotations : lexer discards comment close in nested comment
#10277: ApiAnnotations : lexer discards comment close in nested comment -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (Parser) | Operating System: Unknown/Multiple Keywords: | Type of failure: None/Unknown ApiAnnotations | Blocked By: Architecture: | Related Tickets: Unknown/Multiple | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- When parsing a nested comment, such as {{{#!hs {- {- nested comment -} {-# nested pragma #-} -} }}} The lexer returns the comment annotation as {{{#!hs {- {- nested comment {-# nested pragma # -} }}} Restore the missing comment end markers in the annotation. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10277> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10277: ApiAnnotations : lexer discards comment close in nested comment -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: new Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (Parser) | Keywords: Resolution: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D829 -------------------------------------+------------------------------------- Changes (by alanz): * differential: => Phab:D829 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10277#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10277: ApiAnnotations : lexer discards comment close in nested comment -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: patch Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (Parser) | Keywords: Resolution: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D829 -------------------------------------+------------------------------------- Changes (by alanz): * status: new => patch -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10277#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10277: ApiAnnotations : lexer discards comment close in nested comment -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: patch Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (Parser) | Keywords: Resolution: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D829 -------------------------------------+------------------------------------- Comment (by Austin Seipp <austin@…>): In [changeset:"5fded20c51ae61770f909351c851aaca3d3e331c/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="5fded20c51ae61770f909351c851aaca3d3e331c" ApiAnnotations : lexer discards comment close in nested comment When parsing a nested comment, such as {- {- nested comment -} {-# nested pragma #-} -} The lexer returns the comment annotation as {- {- nested comment {-# nested pragma # -} Restore the missing comment end markers in the annotation. Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D829 GHC Trac Issues: #10277 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10277#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#10277: ApiAnnotations : lexer discards comment close in nested comment -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: closed Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (Parser) | Keywords: Resolution: fixed | ApiAnnotations Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D829 -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed Comment: Merged to `ghc-7.10`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10277#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC