[GHC] #9682: Implement "Add bifunctor related classes to base"-Proposal
#9682: Implement "Add bifunctor related classes to base"-Proposal -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: new Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Moderate (less | Type of failure: than a day) | None/Unknown Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- See [http://www.haskell.org/pipermail/libraries/2014-April/022844.html original libraries@ proposal] for more details -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: new Priority: normal | Milestone: 7.10.1 Component: Core | Version: Libraries | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Moderate (less Unknown/Multiple | than a day) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D336 | -------------------------------------+------------------------------------- Changes (by hvr): * differential: => Phab:D336 Comment: the first third of this task is up for review at Phab:D336 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: new Priority: normal | Milestone: 7.10.1 Component: Core | Version: Libraries | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Moderate (less Unknown/Multiple | than a day) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: Phab:D336 | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"0a290ca0ad599e40ca15a60cc988640f1cfcb4c2/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="0a290ca0ad599e40ca15a60cc988640f1cfcb4c2" Add new `Data.Bifunctor` module (re #9682) This adds the module `Data.Bifunctor` providing the `Bifunctor(bimap,first,second)` class and a couple of instances This module and the class were previously exported by the `bifunctors` package. In contrast to the original module all `INLINE` pragmas have been removed. Reviewed By: ekmett, austin, dolio Differential Revision: https://phabricator.haskell.org/D336 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Core Libraries | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D336 -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: RyanGlScott (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D336 -------------------------------------+------------------------------------- Changes (by hvr): * status: new => closed * resolution: => fixed Comment: I think we can consider this particular task/ticket accomplished (as it made it into milestone:7.10.1) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D336 -------------------------------------+------------------------------------- Comment (by RyanGlScott): Did {{{Bifoldable}}} and {{{Bitraversable}}} (from the original proposal) not make it in? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal (1/3) -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D336 -------------------------------------+------------------------------------- Comment (by hvr): There wasn't enough time to get the other two classes into shape for milestone:7.10.1, they'll get their own Trac ticket -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal (1/3) -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: #10448 | Blocking: | Differential Revisions: Phab:D336 -------------------------------------+------------------------------------- Changes (by hvr): * related: => #10448 Comment: For the rest of this task see #10448 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal (1/3) -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10448 | Differential Rev(s): Phab:D336 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"270d545d557352d5f264247987ee8388f0812187/ghc" 270d545/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="270d545d557352d5f264247987ee8388f0812187" Add Bifoldable and Bitraversable to base This adds `Data.Bifoldable` and `Data.Bitraversable` from the `bifunctors` package to `base`, completing the migration started in D336. This is fairly straightforward, although there were a suprising amount of reinternal organization in `base` that was needed for this to happen: * `Data.Foldable`, `Data.Traversable`, `Data.Bifoldable`, and `Data.Bitraversable` share some nonexported datatypes (e.g., `StateL`, `StateR`, `Min`, `Max`, etc.) to implement some instances. To avoid code duplication, I migrated this internal code to a new hidden module, `Data.Functor.Utils` (better naming suggestions welcome). * `Data.Traversable` and `Data.Bitraversable` also make use of an identity newtype, so I modified them to use `Data.Functor.Identity.Identity`. This has a ripple effect on several other modules, since I had to move instances around in order to avoid dependency cycles. Fixes #10448. Reviewers: ekmett, hvr, austin, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2284 GHC Trac Issues: #9682, #10448 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal (1/3) -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 8.2.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10448 | Differential Rev(s): Phab:D336 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * cc: ekmett (added) * milestone: 7.10.1 => 8.2.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9682: Implement "Add bifunctor related classes to base"-Proposal (1/3) -------------------------------------+------------------------------------- Reporter: hvr | Owner: ekmett Type: task | Status: closed Priority: normal | Milestone: 7.10.1 Component: Core Libraries | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #10448 | Differential Rev(s): Phab:D336 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: 8.2.1 => 7.10.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9682#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC