#8811: Profiling output jumbled together -------------------------------------+------------------------------------- Reporter: augustss | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Profiling | Version: 7.6.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by thomie): * component: Compiler => Profiling Comment: For reference: the change needs to be made in `rts/Profiling.c`. {{{ fprintf(prof_file, "%6s %11s %5s %5s %5s %5s", "no.", "entries", "%time", "%alloc", "%time", "%alloc"); }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8811#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8811: Profiling output jumbled together -------------------------------------+------------------------------------- Reporter: augustss | Owner: dalaing Type: bug | Status: new Priority: normal | Milestone: Component: Profiling | Version: 7.6.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by dalaing): * owner: => dalaing -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8811#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8811: Profiling output jumbled together -------------------------------------+------------------------------------- Reporter: augustss | Owner: dalaing Type: bug | Status: new Priority: normal | Milestone: Component: Profiling | Version: 7.6.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by thomie): * If you calculate the maximum width of the "no." column, then writing a test will be easier. Otherwise you'd need a test with over >10^4 or 10^5 cost centres, which might need to run for a long time? Just do what you think is reasonable, maybe no extra test is needed. * To be sure: the line I referenced above is only for the header. The function `logCCS` needs to be updated as well. * I think all the .prof.sample files in the output will need to be updated afterwards. You might want to make sure they are up-to-date before making any changes. See [wiki:Building/RunningTests/Updating]. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8811#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8811: Profiling output jumbled together -------------------------------------+------------------------------------- Reporter: augustss | Owner: dalaing Type: bug | Status: new Priority: normal | Milestone: Component: Profiling | Version: 7.6.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D779 -------------------------------------+------------------------------------- Comment (by dalaing): I've updated a few things, including logCCS. Some of the constants in the file / formatting string seemed to be out by 1. I'm not sure a new test is needed, although I definitely need to update the .prof.sample files. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8811#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8811: Profiling output jumbled together -------------------------------------+------------------------------------- Reporter: augustss | Owner: dalaing Type: bug | Status: patch Priority: normal | Milestone: Component: Profiling | Version: 7.6.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D779 -------------------------------------+------------------------------------- Comment (by Thomas Miedema ): In [changeset:"c81e07063dd4f792d65f5933cfb906620d120b24/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="c81e07063dd4f792d65f5933cfb906620d120b24" Stop profiling output from running together (#8811) Reviewed By: thomie Differential Revision: https://phabricator.haskell.org/D779 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8811#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler