[GHC] #7708: sys/cpuset.h cannot be found on FreeBSD
#7708: sys/cpuset.h cannot be found on FreeBSD --------------------------------+------------------------------------------- Reporter: kazu-yamamoto | Owner: Type: bug | Status: new Priority: normal | Component: Build System Version: 7.7 | Keywords: Os: FreeBSD | Architecture: Unknown/Multiple Failure: Building GHC failed | Blockedby: Blocking: | Related: --------------------------------+------------------------------------------- Current "configure.ac" cannot detect "sys/cpuset.h" even if it exists on FreeBSD 9.1: {{{ checking sys/cpuset.h presence... yes configure: WARNING: sys/cpuset.h: present but cannot be compiled configure: WARNING: sys/cpuset.h: check for missing prerequisite headers? configure: WARNING: sys/cpuset.h: see the Autoconf documentation configure: WARNING: sys/cpuset.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/cpuset.h: proceeding with the compiler's result configure: WARNING: ## ----------------------------------------------- ## configure: WARNING: ## Report this to glasgow-haskell-bugs@haskell.org ## configure: WARNING: ## ----------------------------------------------- ## checking for sys/cpuset.h... no }}} This is because sys/param.h should be included in the test. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD --------------------------------+------------------------------------------- Reporter: kazu-yamamoto | Owner: Type: bug | Status: new Priority: normal | Component: Build System Version: 7.7 | Keywords: Os: FreeBSD | Architecture: Unknown/Multiple Failure: Building GHC failed | Blockedby: Blocking: | Related: --------------------------------+------------------------------------------- Comment(by kazu-yamamoto): The attached patch fixes this. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD ---------------------------------+------------------------------------------ Reporter: kazu-yamamoto | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.7 Keywords: | Os: FreeBSD Architecture: Unknown/Multiple | Failure: Building GHC failed Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Changes (by igloo): * status: new => patch * difficulty: => Unknown -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD ---------------------------------+------------------------------------------ Reporter: kazu-yamamoto | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.7 Keywords: | Os: FreeBSD Architecture: Unknown/Multiple | Failure: Building GHC failed Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Comment(by kazu-yamamoto): What stops merging this patch? -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD ---------------------------------+------------------------------------------ Reporter: kazu-yamamoto | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.7 Keywords: | Os: FreeBSD Architecture: Unknown/Multiple | Failure: Building GHC failed Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Comment(by ezyang): I think probably people want to test the patch independently and make sure it works, but I don't have a BSD box handy for that :( Question about a hunk: {{{ +AC_CHECK_HEADERS([sys/cpuset.h], [], [], +[[#if HAVE_SYS_PARAM_H +# include <sys/param.h> +#endif +]]) }}} What is going on here? -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD ---------------------------------+------------------------------------------ Reporter: kazu-yamamoto | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.7 Keywords: | Os: FreeBSD Architecture: Unknown/Multiple | Failure: Building GHC failed Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Comment(by kazu-yamamoto): Manpage of cpuset_getaffinity() says: {{{ #include <sys/param.h> #include <sys/cpuset.h> }}} This bug happens because the check program only includes sys/cpuset.h. The patch first checks whether or not sys/param.h exist. If exists, check whether or not sys/cpuset.h exist with sys/param.h included. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD ---------------------------------+------------------------------------------ Reporter: kazu-yamamoto | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Build System | Version: 7.7 Keywords: | Os: FreeBSD Architecture: Unknown/Multiple | Failure: Building GHC failed Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Comment(by ian@…): commit 4a8e254cbc16b3a4f264c4dda15d8eeddd13abc7 {{{ Author: Ian Lynagh <ian@well-typed.com> Date: Fri Mar 1 00:50:47 2013 +0000 Fix sys/cpuset.h on FreeBSD 9.1; patch from kazu-yamamoto; fixes #7708 configure.ac | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7708: sys/cpuset.h cannot be found on FreeBSD ----------------------------------+----------------------------------------- Reporter: kazu-yamamoto | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Build System | Version: 7.7 Resolution: fixed | Keywords: Os: FreeBSD | Architecture: Unknown/Multiple Failure: Building GHC failed | Difficulty: Unknown Testcase: | Blockedby: Blocking: | Related: ----------------------------------+----------------------------------------- Changes (by igloo): * status: patch => closed * resolution: => fixed Comment: Applied, thanks! -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7708#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC