#14627: qAddTopDecls: can't convert top-level declarations -------------------------------------+------------------------------------- Reporter: tianxiaogu | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Template Haskell | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * os: Linux => Unknown/Multiple * component: Compiler => Template Haskell * architecture: x86_64 (amd64) => Unknown/Multiple -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14627#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#14627: qAddTopDecls: can't convert top-level declarations -------------------------------------+------------------------------------- Reporter: tianxiaogu | Owner: mgsloan Type: bug | Status: new Priority: normal | Milestone: Component: Template Haskell | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mgsloan): I've put up a patch that makes addTopDelcs no longer panic for conversion errors: https://phabricator.haskell.org/D4914 . Instead they are reported as normal errors like this: {{{ T14627.hs:3:3: error: qAddTopDecls: can't convert declarations: Illegal variable name: ‘Bool’ When splicing a TH declaration: f_0 = Bool | 3 | $(do | ^^... }}} Atop this, the error "Illegal variable name: 'Bool'" is quite poor, instead it should just say there's an out of scope constructor. I have a patch that fixes this and adds documentation to `UnboundVarE` clarifying this case. Can't push it to phabricator yet, though, because it appears to be down. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14627#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#14627: qAddTopDecls: can't convert top-level declarations -------------------------------------+------------------------------------- Reporter: tianxiaogu | Owner: mgsloan Type: bug | Status: new Priority: normal | Milestone: Component: Template Haskell | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4914 Wiki Page: | -------------------------------------+------------------------------------- Comment (by mgsloan): In addition to D4914, which changes this from panic-ing to just a regular error, I've also published https://phabricator.haskell.org/D4923 which improves the error for this specific case. Instead it says "Data constructor not in scope: Bool" -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14627#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#14627: qAddTopDecls: can't convert top-level declarations -------------------------------------+------------------------------------- Reporter: tianxiaogu | Owner: mgsloan Type: bug | Status: patch Priority: normal | Milestone: Component: Template Haskell | Version: 8.2.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: th/T14627 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4914 Wiki Page: | -------------------------------------+------------------------------------- Changes (by mgsloan): * cc: th/T14627 (removed) * testcase: => th/T14627 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14627#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#14627: qAddTopDecls: can't convert top-level declarations -------------------------------------+------------------------------------- Reporter: tianxiaogu | Owner: mgsloan Type: bug | Status: closed Priority: normal | Milestone: 8.6.1 Component: Template Haskell | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: th/T14627 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4914 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed * milestone: => 8.6.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14627#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#14627: qAddTopDecls: can't convert top-level declarations -------------------------------------+------------------------------------- Reporter: tianxiaogu | Owner: mgsloan Type: bug | Status: closed Priority: normal | Milestone: 8.8.1 Component: Template Haskell | Version: 8.2.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Compile-time | Unknown/Multiple crash or panic | Test Case: th/T14627 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4914 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"774f366ebe58023fc50ba346894227b14816fe67/ghc" 774f366/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="774f366ebe58023fc50ba346894227b14816fe67" Fail instead of panic-ing when qAddTopDecls has conversion error See https://ghc.haskell.org/trac/ghc/ticket/14627 for an example where GHC panics when using qAddTopDecls on [d| f = Bool |]. Instead, it should be a normal error message, and that's what this change is for. It does not entirely resolve Trac#14627, since "Illegal variable name: 'bool'" isn't a very good error for this cirumstance. Test Plan: Manually tested. Reviewers: goldfire, bgamari Reviewed By: goldfire Subscribers: rwbarton, thomie, carter Differential Revision: https://phabricator.haskell.org/D4914 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14627#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler