#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by thomie): Phab:D783 filters out `-Rghc-timing` for `V=0` builds. I didn't make any changes to the default `V=1` build, as `-Rghc-timing` has been part of that default since at least the beginning of the century, some people might depend on it, and it could be useful for bug reports. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10223#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema ): In [changeset:"43351ff0905a098c382487c502ccad53783ba9ee/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="43351ff0905a098c382487c502ccad53783ba9ee" Filter out `-Rghc-timing` for V=0 builds (#10223) Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D783 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10223#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema ): In [changeset:"4c1e1c870e294990a44d8d6837742fb0d00f5456/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="4c1e1c870e294990a44d8d6837742fb0d00f5456" Disable same warnings for normal builds as for validate (#10223) The default validate settings currently disable some warnings in the libraries. This patch moves those settings to a new file called `mk/warnings.mk`, and applies them also to normal builds. Through uncommenting a line in build.mk, developers can now build with -Werror. -Werror is not the default, because: * We can not guarantee that the build is warning free on platforms we don't run regularly run validate (as part of continuous integration systems), and we still want the build to go through on those platforms. * quoting rwbarton on irc > "I think -Werror by default has come up in the past and the argument was that it is too annoying when you are doing nontrivial development" Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D785 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10223#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema ): In [changeset:"2c24fd707f8650205bb574ffac5f376239af3723/ghc" 2c24fd70/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="2c24fd707f8650205bb574ffac5f376239af3723" Build system: put each BuildFlavour in a separate file (#10223) This allows easier diffing of different BuildFlavours, including `mk/flavours/validate.mk`. Reviewed By: bgamari, austin Differential Revision: https://phabricator.haskell.org/D1050 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10223#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema ): In [changeset:"330fbbdacc71a7bb465195e24e268a947fe97412/ghc" 330fbbda/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="330fbbdacc71a7bb465195e24e268a947fe97412" Build system: make *-cross BuildFlavours consistent (#10223) This is a follow up to 841924c9587c10488a18e307b573720977bf4f13, where `-fllvm` was explicitly removed from GhcStage1HcOpts for perf-cross. After removing -fllvm from GhcStage1HcOpts, it should be removed from SRC_HC_OPTS as well, because SRC_HC_OPTS are added to every Haskell compilation. That's what this patch does. BuildFlavour bench-cross (added in ddf79ebf69fe4a6e69d69d451a6040a53b1ea12c), is probably never used. But for consistency, also use -fllvm here, for building stage2 and the libraries. Reviewed by: austin Differential Revision: https://phabricator.haskell.org/D1228 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10223#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10223#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler