#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by goldfire): I vote to remove `-Rghc-timing` from this file. Note that it has to be removed from this file, and also somewhere(?) else. I currently put `GhcHcOpts =` in my `build.mk`s to make sure this output is squashed. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10223#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"3749c05216339df60e1ffbb28c8b957ad5020b00/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="3749c05216339df60e1ffbb28c8b957ad5020b00" Reformat build flavours in build.mk.sample (#10223) Use same format for each build flavour, to make it easier to compare them. Refactoring only. Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D782 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10223#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"4c1e1c870e294990a44d8d6837742fb0d00f5456/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="4c1e1c870e294990a44d8d6837742fb0d00f5456" Disable same warnings for normal builds as for validate (#10223) The default validate settings currently disable some warnings in the libraries. This patch moves those settings to a new file called `mk/warnings.mk`, and applies them also to normal builds. Through uncommenting a line in build.mk, developers can now build with -Werror. -Werror is not the default, because: * We can not guarantee that the build is warning free on platforms we don't run regularly run validate (as part of continuous integration systems), and we still want the build to go through on those platforms. * quoting rwbarton on irc > "I think -Werror by default has come up in the past and the argument was that it is too annoying when you are doing nontrivial development" Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D785 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10223#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Description changed by thomie: Old description: New description: The goal is to make build.mk.sample easier to understand for GHC developers. There are currently 13 BuildFlavours available to us. It should be clear what the differences between them are, and if those differences are put there on purpose or it they are bugs. There is a certain amount of cargo culting going on in build.mk.sample, with settings just left alone for years because nobody dares touching them (-H64m -fasm) (or nobody cares). Quiz question: what is the difference between the quick and the devel2 build is. We should try to keep the changes backward-compatible, because there are blog posts etc out there that refer to the existing BuildFlavours. -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10223#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"b40e55954ecdab650d35349cbb93e53df952310e/ghc" b40e559/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="b40e55954ecdab650d35349cbb93e53df952310e" Build system: simplify *-llvm BuildFlavours (#10223) Note that SRC_HC_OPTS are added to every Haskell compilation. So there isn't any need to also add `-fllvm` to GhcStage1HcOpts, GhcStage2HcOpts and GhcLibHcOpts. Small bug fix: make sure we test for -fllvm in SRC_HC_OPTS, to check whether the bootstrap compiler is affected by bug #9439. Reviewed by: austin Differential Revision: https://phabricator.haskell.org/D1188 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10223#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

#10223: Cleanup `mk/build.mk.sample` -------------------------------------+------------------------------------- Reporter: thomie | Owner: thomie Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.10.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by thomie): Todo: * figure out the `-H64m` story. See https://mail.haskell.org/pipermail /glasgow-haskell-users/2015-May/025917.html. I found this bit of wisdom by Simon Marlow, https://mail.haskell.org/pipermail/ghc-devs/2014-March/004344.html:

...

Just wondering: that '-H64m' is from some old times (pre 2007?). GHC seems to eat way more RAM nowadays. Is this bit relevant at all?

It still speeds up compilation a bit, but a larger -H value might be more appropriate > for today's machines.

-- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10223#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler