#3379: GHC should use the standard binary package -------------------------------------+------------------------------------- Reporter: igloo | Owner: Type: task | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 6.10.4 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by thomie): * cc: kolmodin, jstolarek (added) Comment: The binary package received a portable implementation of `instance Binary Integer` in the following commit: https://github.com/kolmodin/binary/commit/2109b28f4d3919dbedcf42c97e51471165... GHC's version looks like this: {{{ instance Binary Integer where -- XXX This is hideous put_ bh i = put_ bh (show i) get bh = do str <- get bh case reads str of [(i, "")] -> return i _ -> fail ("Binary Integer: got " ++ show str) }}} As mentioned in Phab:D1165, `compiler/utils/Binary.hs` contains also a commented out implementation of `instance Binary Integer`. It is supposedly more efficient than the one in the `binary` package (but not portable?). This should all be cleared and cleaned up. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/3379#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler