[GHC] #8878: Export runTcInteractive from TcRnDriver
#8878: Export runTcInteractive from TcRnDriver -------------------------------------------+------------------------------- Reporter: holzensp | Owner: Type: feature request | Status: new Priority: lowest | Milestone: 7.8.1 Component: Compiler | Version: 7.6.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 hour) | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: -------------------------------------------+------------------------------- For people writing more involved code onto GHC than the normal API (GHC.hs) allows, this is a very useful function. In previous versions of GHC, it has always been unclear to me how I should run the type checker on, for example, a single expression, while keeping the context (i.e. when running the type checker again, the types derived in the former run should still be known in the latter). Simply having runTcInteractive exported does wonders for self-documentation purposes. (patch to follow shortly) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8878: Export runTcInteractive from TcRnDriver -------------------------------+------------------------------------------- Reporter: holzensp | Owner: holzensp Type: feature | Status: new request | Milestone: 7.8.1 Priority: lowest | Version: 7.6.3 Component: Compiler | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by holzensp): * owner: => holzensp -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8878: Export runTcInteractive from TcRnDriver
-------------------------------+-------------------------------------------
Reporter: holzensp | Owner: holzensp
Type: feature | Status: new
request | Milestone: 7.8.1
Priority: lowest | Version: 7.6.3
Component: Compiler | Keywords:
Resolution: | Architecture: Unknown/Multiple
Operating System: | Difficulty: Easy (less than 1 hour)
Unknown/Multiple | Blocked By:
Type of failure: | Related Tickets:
None/Unknown |
Test Case: |
Blocking: |
-------------------------------+-------------------------------------------
Comment (by Simon Peyton Jones
#8878: Export runTcInteractive from TcRnDriver -------------------------------+------------------------------------------- Reporter: holzensp | Owner: holzensp Type: feature | Status: new request | Milestone: 7.8.1 Priority: lowest | Version: 7.6.3 Component: Compiler | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by simonpj): OK I've done this, and also exported it from module GHC, which is supposed to be the API that clients use. Is it important to merge this into 7.8? It is very late in the day, but its a very innocuous change. Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8878: Export runTcInteractive from TcRnDriver -------------------------------+------------------------------------------- Reporter: holzensp | Owner: holzensp Type: feature | Status: merge request | Milestone: 7.8.1 Priority: lowest | Version: 7.8.1-rc2 Component: Compiler | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by thoughtpolice): * status: new => merge * version: 7.6.3 => 7.8.1-rc2 Comment: A minor API addition like this isn't really a big deal IMO. It can go in the queue. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8878: Export runTcInteractive from TcRnDriver -------------------------------+------------------------------------------- Reporter: holzensp | Owner: holzensp Type: feature | Status: merge request | Milestone: 7.8.1 Priority: lowest | Version: 7.8.1-rc2 Component: Compiler | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by holzensp): I didn't include the export in GHC, because of Simon M's argument on the mailing list [1] that GHC doesn't export TcRn, which is required for runTcInteractive. I'm fine with it either way, though. Methinks it is a rather harmless change, so I see no issue with including it in 7.8 as you have now done. Thanks much ;) [1] http://www.haskell.org/pipermail/ghc-devs/2014-February/004013.html -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8878: Export runTcInteractive from TcRnDriver -------------------------------+------------------------------------------- Reporter: holzensp | Owner: holzensp Type: feature | Status: merge request | Milestone: 7.8.1 Priority: lowest | Version: 7.8.1-rc2 Component: Compiler | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by simonpj): I don't really care either, but my inclination is that if it's something we expect GHC-API clients to call, it should be exported by GHC. You want `runTcInterative`, but presumably to make use of it you also need some other functions in the `TcRn` monad. So probably it alone isn't enough. Identifying a useful set would be a Good Thing. Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#8878: Export runTcInteractive from TcRnDriver -------------------------------+------------------------------------------- Reporter: holzensp | Owner: holzensp Type: feature | Status: closed request | Milestone: 7.8.1 Priority: lowest | Version: 7.8.1-rc2 Component: Compiler | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Easy (less than 1 hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by thoughtpolice): * status: merge => closed * resolution: => fixed Comment: Merged in 7.8. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8878#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC