[GHC] #11209: Please add platform detection support for sh4 (Hitachi SuperH)
#11209: Please add platform detection support for sh4 (Hitachi SuperH) --------------------------------+------------------------------------- Reporter: glaubitz | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Keywords: | Operating System: Unknown/Multiple Architecture: Other | Type of failure: None/Unknown Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: --------------------------------+------------------------------------- Hello! I am currently bootstrapping ghc for sh4 in Debian. In order to get the ghc build scripts detect sh4 as a valid architecture, I had to make local changes to aclocal.m4. With these changes, sh4 is properly detected as an architecture and I can both cross-build for sh4 as well as build ghc on this platform natively. Please apply the supplied patch so that we do not have to carry this patch in the Debian package [1] anymore. Thanks, Adrian
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807108
-- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11209 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11209: Please add platform detection support for sh4 (Hitachi SuperH) -------------------------------------+------------------------------ Reporter: glaubitz | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Other Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------ Changes (by glaubitz): * Attachment "sh4-platform-detection-support.patch" added. Patch aclocal.m4 to detect sh4 as a valid but unknown architecture -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11209 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11209: Please add platform detection support for sh4 (Hitachi SuperH) -------------------------------------+------------------------------ Reporter: glaubitz | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Other Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------ Comment (by glaubitz): slyfox on #ghc just pointed at this commit which shows the same procedure for Alpha and other architectures [1]. Would be great if sh4 could be added in a similar way. Thanks, Adrian
[1] https://git.haskell.org/ghc.git/commitdiff/9756690fe7aa26aee6955d0b720377d53...
-- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11209#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11209: Please add platform detection support for sh4 (Hitachi SuperH)
-------------------------------------+------------------------------
Reporter: glaubitz | Owner:
Type: bug | Status: new
Priority: normal | Milestone:
Component: Compiler | Version: 7.10.2
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture: Other
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+------------------------------
Comment (by Sergei Trofimovich
#11209: Please add platform detection support for sh4 (Hitachi SuperH) ----------------------------------------+------------------------------ Reporter: glaubitz | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Other Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | ----------------------------------------+------------------------------ Changes (by slyfox): * status: new => closed * failure: None/Unknown => Building GHC failed * resolution: => fixed * milestone: => 8.0.1 Comment: Pushed. Thank you! In ''sh4'' case you don't need to add ''sh4'' as a known arch as there is no special code that behaves differently. In ''sparc64'' case you would need to add ''ArchSPARC64'' as you need to switch on arch type to disable ''--relax'' as ''sparc32'' does: http://git.haskell.org/ghc.git/blob/f48015bcac59960f6d266506a5f378c9bcf8f005... changeset:9756690fe7aa26aee6955d0b720377d53170c542 introduces ''ArchAlpha'' and friends to set ''bewareLoadStoreAlignment = True''. Default for ''UnknownArch'' was ''False''. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11209#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11209: Please add platform detection support for sh4 (Hitachi SuperH) ----------------------------------------+------------------------------ Reporter: glaubitz | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Other Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | ----------------------------------------+------------------------------ Comment (by glaubitz): Thanks, but you could have set the author name and email to my name in the commit. Would have been my first official commit to ghc :(. Cheers, Adrian -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11209#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11209: Please add platform detection support for sh4 (Hitachi SuperH) ----------------------------------------+------------------------------ Reporter: glaubitz | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Other Type of failure: Building GHC failed | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | ----------------------------------------+------------------------------ Comment (by slyfox): My apologies, did not follow the links to get preferred author identity and applied patch as is. I suggest using ''git commit'' / ''git format-patch'' next time. That way ''git am'' would do the right thing preserving the origin. Or you can submit patch for review using ''arc diff'': https://ghc.haskell.org/trac/ghc/wiki/Phabricator and get all the advantages of the presubmit build system. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11209#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC