[GHC] #10664: T8131 times out on master

older
Re: [GHC] #3306: Improve syntax...

GHC

21 Jul 2015 21 Jul '15

1:10 p.m.

#10664: T8131 times out on master -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Revisions: | -------------------------------------+------------------------------------- The testsuite test `codeGen/should_fail/T8131` appears to time out on the `master` branch as of today. This isn't counted as a testsuite failure as it is a should-fail test, but nevertheless something is not right as it doesn't terminate despite being allowed to run for several minutes. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10664 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Show replies by date

GHC

21 Jul 21 Jul

1:14 p.m.

GHC

1:14 p.m.

GHC

1:15 p.m.

GHC

22 Jul 22 Jul

3:29 p.m.

GHC

3 Aug 3 Aug

9:07 a.m.

#10664: T8131 times out on master -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by bgamari): Hmm, it seems like some knot-typing in `FCode` may be going wrong. I've been chasing this down with the profiler and `-xc` and it appears that we're getting stuck in `StgCmmMonad.fixC`. It appears that the only user of this is `StgCmmExtCode.loopDecls`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10664#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

9:21 a.m.

#10664: T8131 times out on master -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by bgamari): The issue appears to be triggered by the fourth argument of the `%memcpy` call being non-constant, {{{ // This fails testMemcpy (W_ dst, W_ src, W_ l, W_ sz) { prim %memcpy(dst, src, l, sz); return (); } // This also fails testMemcpy (W_ dst, W_ src, W_ l, W_ sz) { W_ a; a = 0; prim %memcpy(dst, src, l, a); return (); } // But this succeeds testMemcpy (W_ dst, W_ src, W_ l, W_ sz) { prim %memcpy(dst, src, l, 0); return (); } }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10664#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

9:28 a.m.

#10664: T8131 times out on master -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by bgamari): It appears that this is due to a rework I made for the LLVM backend, 681973c31c614185229bdae4f6b7ab4f6e64753d. Here I explicitly forced the alignment argument to `%memcpy` calls to ensure that `pprPgmError` fired. I did this as otherwise the should-fail test I introduced to test the feature would fail in the case of the NCG (which apparently sometimes never forces the alignment). Admittedly this was a bit of a large hammer to just make some tests pass. I'm going to remove the `seq` and just only run the test against the LLVM backend. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10664#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

9:34 a.m.

GHC

11:21 a.m.

#10664: T8131 times out on master -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"64b6733e217f32feb8c4872096749c6f417d0c39/ghc" 64b6733e/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="64b6733e217f32feb8c4872096749c6f417d0c39" CmmParse: Don't force alignment in memcpy-ish operations This was initially made in 681973c31c614185229bdae4f6b7ab4f6e64753d. Here I wanted to enforce that the alignment passed to %memcpy was a constant expression, as this is required by LLVM. However, this breaks the knot-tying done in `loopDecls`, causing T8131 to hang. Here I remove the `seq` and mark T8131 as `expect_broken` in the case of the NCG, which doesn't force the alignment in this case. Fixes #10664. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10664#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

12:33 p.m.

#10664: T8131 times out on master -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: closed Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.11 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10664#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

3582

Age (days ago)

3595

Last active (days ago)

List overview

Download

10 comments

1 participants

[GHC] #10664: T8131 times out on master

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

tags

participants (1)