[GHC] #11454: Do not suggest deprecated flags
#11454: Do not suggest deprecated flags -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Keywords: newcomer | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- When you misspell the name of a flag, GHC outputs a nice list of similar flags that do exist: {{{ $ ghc-8.0.1 -W-redundant-constraints ghc: unrecognised flag: -W-redundant-constraints did you mean one of: -Wredundant-constraints -Wno-redundant-constraints -fwarn-redundant-constraints }}} But since the `-fwarn` flags are deprecated, they should not be suggested. Neither should any of the other deprecated flags. For a newcomer: the code is `compiler/main/DynFlags.hs`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11454> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11454: Do not suggest deprecated flags -------------------------------------+------------------------------------- Reporter: thomie | Owner: nkartashov Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by nkartashov): * owner: => nkartashov -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11454#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11454: Do not suggest deprecated flags -------------------------------------+------------------------------------- Reporter: thomie | Owner: nkartashov Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1883 Wiki Page: | -------------------------------------+------------------------------------- Changes (by nkartashov): * differential: => Phab:D1883 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11454#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11454: Do not suggest deprecated flags -------------------------------------+------------------------------------- Reporter: thomie | Owner: nkartashov Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1883 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"46af6835ac68d104ee56c29afdfa523c165db2fb/ghc" 46af6835/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="46af6835ac68d104ee56c29afdfa523c165db2fb" compiler: Do not suggest nor complete deprecated flags fix trac issue #11454 Previously, all flags were present in user suggest and completion. This commit removes the deprecated ones from there. It is done by saving deprecation info at the moment of flag definition. Reviewers: rwbarton, austin, bgamari Reviewed By: bgamari Subscribers: rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D1883 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11454#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11454: Do not suggest deprecated flags -------------------------------------+------------------------------------- Reporter: thomie | Owner: nkartashov Type: task | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.3 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1883 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * failure: None/Unknown => Incorrect warning at compile-time * resolution: => fixed * milestone: => 8.0.1 Comment: This was also merged to `ghc-8.0`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11454#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11454: Do not suggest deprecated flags -------------------------------------+------------------------------------- Reporter: thomie | Owner: nkartashov Type: task | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.10.3 Resolution: fixed | Keywords: newcomer Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1883 Wiki Page: | -------------------------------------+------------------------------------- Comment (by thomie): Thanks @nkartashov and @bgamari! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11454#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC