#8959: GHCi should honour UnicodeSyntax -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by hvr): What about compiler errors/warnings? Should those use `UnicodeSyntax` as well if enabled? What about `ghc`'s compile messages in general? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: nomeata Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by Joachim Breitner ): In [changeset:"819e1f2c2e10268fe3edc8395f2707b93c9c6f4d/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="819e1f2c2e10268fe3edc8395f2707b93c9c6f4d" Use UnicodeSyntax when printing When printing Haskell source, and UnicodeSyntax is enabled, use the unicode sytax characters (#8959). }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: nomeata Type: bug | Status: closed Priority: low | Milestone: Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by nomeata): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Changes (by nomeata): * owner: nomeata => * status: closed => new * resolution: fixed => Comment: I just noticed that my patch only works if `-XUnicodeSyntax` is passed on the command line, or set with `:set`. It does not work simply because you load a file with `LANGUAGE UnicodeSyntax`. Should it? Other pragmas (tested it with `RankNTypes`) in a loaded file also don’t affect what you enter at GHCi. Also, the pragma does not have an effect on the error message printed by the compiler in error messages from a file with `UnicodeSyntax` active. The `dynflag` passed to the pretty-printer seems to be a different one than used when type-checking. (Reopening) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by hvr): Replying to [comment:7 nomeata]:

Should it? Other pragmas (tested it with `RankNTypes`) in a loaded file also don’t affect what you enter at GHCi.

Btw, the prompt is usually affected by `:seti -X...` rather than `:set -X...` -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------+------------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: closed Priority: low | Milestone: 7.10.1 Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Easy (less than 1 hour) Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by nomeata): Sigh: #3217 is not all there is to fix. Independent of GHCi we seem to want error messages from modules with `UnicodeSyntax` printed with that syntax. So we need to instrument `SDoc` in error messages with the settings from where the setting originated. The `dynflags` passed in `SDocContext` does not work for this, as they are the dynflags in scope when the error is printed, i.e. outside the module scope. There is precedence: The `PrintUnqualified` field of `ErrMsg` and later of `PprUser` transports information about how to pretty print stuff from the location of error to when its `SDoc` is rendered. I added a `Bool` there to indicate whether `UnicodeSyntax` should be used and it seems to work, but I’m not satisfied with this design. Stored the change in the `wip/T8959` branch, see [changeset:4a4e684f4/ghc]. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by int-e): I'm unhappy with this change, because it uses a language extension that affects accepted **input** (namely, `UnicodeSyntax`) to modify the **output** of ghci. I would prefer having a ghci-specific option (say, `:set +/-u` or more verbosely, `:set +/-unicodeoutput`) instead. This is not just cosmetics; the current behaviour broke lambdabot's `:t` and `:k` commands, which parse ghci's output. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:14 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by nomeata): The reference to `-XExplicitForAll` vs. `-fprint-explicit-foralls` is a good point.. But it’s already released, so any tools that are broken will likely get a fix anyways. I’m unsure on how to proceed here. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:16 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by int-e): I've implemented the simple semantics where `-fprint-unicode-syntax` determines whether printing types and kind uses unicode syntax or not. The three-state behaviour from comment 17 would require more work. In any case I'm now using this implementation with lambdabot. (The patch is against ghc's HEAD; a patch for ghc-7.10.1 can be found in lambdabot's repository: https://github.com/lambdabot/lambdabot/blob/freenode/patches/ghc-7.10.1.patc...) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:18 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D807 -------------------------------------+------------------------------------- Comment (by int-e): Replying to [comment:18 int-e]:

The three-state behaviour from comment 17 would require more work.

Perhaps more importantly, it would be more difficult to explain to users. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:20 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: new Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D807 -------------------------------------+------------------------------------- Comment (by int-e): Is there a chance of getting the -fprint-unicode-syntax flag into 7.10.2? Personally I think the chances of breaking anything are slim, but it's not an easy call to make. (I still regret that I didn't find this in the RCs) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:22 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: merge Priority: low | Milestone: 7.10.2 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D807 -------------------------------------+------------------------------------- Changes (by thomie): * status: new => merge * milestone: 7.12.1 => 7.10.2 Comment: I think work is done here. int-e is asking for a merge to 7.10.2 of 6dd2765a300bb139b4ab67688dbc6f48de66969b -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:24 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: Type: bug | Status: merge Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D807 -------------------------------------+------------------------------------- Changes (by thoughtpolice): * milestone: 7.10.2 => 7.12.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:26 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#8959: GHCi should honour UnicodeSyntax -------------------------------------+------------------------------------- Reporter: Fuuzetsu | Owner: (none) Type: bug | Status: closed Priority: low | Milestone: 8.0.1 Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D807 -------------------------------------+------------------------------------- Comment (by Krzysztof Gogolewski ): In [changeset:"d555d4beb457f485aa122d118903f6f926f054f8/ghc" d555d4be/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="d555d4beb457f485aa122d118903f6f926f054f8" Use unicode arrows with -fprint-unicode-syntax Summary: See #8959, this is one more place where we can pretty-print Unicode syntax. Test Plan: validate Reviewers: nomeata, bgamari Reviewed By: bgamari Subscribers: rwbarton, carter GHC Trac Issues: #8959 Differential Revision: https://phabricator.haskell.org/D5439 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8959#comment:29 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler